-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use dynamic links for downloading the latest version of JetBrains Tools #9268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, in prod, we have daily build scripts that release the latest IDE every day, so this doesn't expire |
The value here should only affect the preview environment |
As @iQQBot said these images only are used in prev envs to test changes against latest version. We do need to realign them from to time by changing |
@iQQBot maybe we actually try this approach? I would expect that it is only relevant when someone is changing let's say JB backend plugin which should trigger rebuild of images anyway? We could also add then instead some env var in Docker image to explicitly retrigger rebuild if image is stale, but need to be updated. WDYT? |
fa8d2d1
to
38e892b
Compare
38e892b
to
5e58d34
Compare
2ec54bd
to
85c261b
Compare
85c261b
to
c5bc40f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try
nice find btw
Description
EAP versions of JetBrains Tools have an expiration date. So we need to keep constantly updating the build config for picking up the latest version (be it EAP, RC, or even the stable release if it was the last one published).
This PR makes the latest versions to be downloaded from dynamic links provided by JetBrains API, to ensure we never get the following error again:
Note the
This IDE build has expired. Please download a new build from JetBrains official site
message in the snippet above.Related Issue(s)
NONE
How to test
Open any JetBrains Tool with "Latest" checkbox checked and confirm it works.
Alternatively, you can access the download links on your browser and confirm they're all working:
Release Notes
Documentation
NONE