-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[public-api-server] Add k8s deployment into installer #9258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c5e91d
to
04195fe
Compare
4a0f6ce
to
f61f0c4
Compare
04195fe
to
0d57355
Compare
40 tasks
c8c1ec7
to
97e97a9
Compare
3ddaa70
to
642b33d
Compare
Please enter the commit message for your changes. Lines starting
642b33d
to
1854bac
Compare
easyCZ
commented
Apr 13, 2022
"k8s.io/apimachinery/pkg/runtime" | ||
) | ||
|
||
func rolebinding(ctx *common.RenderContext) ([]runtime.Object, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely a mirror of dashboard
config.
@@ -26,5 +33,68 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
publicAPIConfig := experimentalCfg.WebApp.PublicAPI | |||
log.Debug("Detected experimental.WebApp.PublicApi configuration", publicAPIConfig) | |||
|
|||
return nil, nil | |||
labels := common.DefaultLabels(Component) | |||
return []runtime.Object{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirror of dashboard deployment config
andrew-farries
approved these changes
Apr 13, 2022
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: webapp
Meta team change is running in production
deployed
Change is completely running in production
release-note-none
size/L
team: webapp
Issue belongs to the WebApp team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generates a deployment config for k8s, including rolebinding and service account:
With experimental config
generates
Without experimental config, no
public-api-server
is renderedRelated Issue(s)
Depends on #9252
Part of #9229
How to test
Inspect rendered.yaml it contains the config.
Release Notes
Documentation
/uncc
/hold