[public-api-server] Simple gRPC server #9290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
suggested changes
Apr 13, 2022
Comment on lines
+23
to
+27
| addr := ":9000" | ||
| fmt.Println("Serving HTTP", addr) | ||
| err := http.ListenAndServe(addr, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| _, _ = w.Write([]byte(`hello world\n`)) | ||
| })) |
There was a problem hiding this comment.
Do we still need this http server in addition to the GRPC server below?
There was a problem hiding this comment.
Yes. We'll need to serve metrics, ready/health endpoints etc
andrew-farries
previously approved these changes
Apr 13, 2022
Please enter the commit message for your changes. Lines starting
easyCZ
force-pushed
the
mp/papi-grpc-server
branch
from
908df84 to
cb7fa74
Compare
andrew-farries
approved these changes
Apr 13, 2022
40 tasks
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends public-api-server with a simple gRPC server. The server doesn't have any services any starts up. This is intended to move us along and allow us to iterate, rather than be a complete and final result.
Graceful shutdown of servers is outside of the scope of this PR and will be tackled in subsequent ones.
Related Issue(s)
Part of #9229
How to test
cd components/public-api-server && go run main.goRelease Notes
Documentation
NONE