-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[baseserver] Add prometheus metrics #9313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
656f2cb
to
d320559
Compare
d320559
to
1674fb5
Compare
/werft run |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-baseserver-metrics.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess we could add a test for the case when the server is constructed with a nil metrics registry, but I leave it up to you if you think such tests are worthwhile.
Will add in a follow-up PR. Thanks! /unhold |
Description
Extends base server (powers
public-api
) with ability to serve prometheus metrics.Related Issue(s)
Part of #9229
Depends on #9300
How to test
Unit tests
Release Notes
Documentation
NONE
/hold