Skip to content

[baseserver] Add prometheus metrics #9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[baseserver] Add prometheus metrics #9313

merged 1 commit into from
Apr 19, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 14, 2022

Description

Extends base server (powers public-api) with ability to serve prometheus metrics.

Related Issue(s)

Part of #9229
Depends on #9300

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

/hold

@easyCZ easyCZ force-pushed the mp/baseserver-metrics branch from d320559 to 1674fb5 Compare April 19, 2022 09:30
@easyCZ easyCZ marked this pull request as ready for review April 19, 2022 09:31
@easyCZ easyCZ requested a review from a team April 19, 2022 09:31
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 19, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 19, 2022

/werft run

@easyCZ
Copy link
Member Author

easyCZ commented Apr 19, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-metrics.4

Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess we could add a test for the case when the server is constructed with a nil metrics registry, but I leave it up to you if you think such tests are worthwhile.

@easyCZ
Copy link
Member Author

easyCZ commented Apr 19, 2022

with a nil metrics registry, but I leave it up to you if you think such tests are worthwhile.

Will add in a follow-up PR. Thanks!

/unhold

@roboquat roboquat merged commit 043b453 into main Apr 19, 2022
@roboquat roboquat deleted the mp/baseserver-metrics branch April 19, 2022 12:48
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants