[baseserver] Allow zero port to automatically assign port #9396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/baseserver-zero-port
branch
from
f7c07f7 to
fed41d5
Compare
40 tasks
easyCZ
force-pushed
the
mp/baseserver-zero-port
branch
3 times, most recently
from
6c28151 to
353fa24
Compare
andrew-farries
previously approved these changes
Apr 19, 2022
easyCZ
force-pushed
the
mp/baseserver-zero-port
branch
from
353fa24 to
a27f2b3
Compare
andrew-farries
previously approved these changes
Apr 19, 2022
andrew-farries
previously approved these changes
Apr 19, 2022
easyCZ
force-pushed
the
mp/baseserver-zero-port
branch
from
d9bed6d to
98a615f
Compare
|
Thanks for the review @andrew-farries, I've had to rebase and sadly it cleared out your review. |
andrew-farries
approved these changes
Apr 19, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix from review in #9300, enabled specifying 0 as the port number for both http and grpc servers. In this scenario,
net.Listen()automatically assigns an open port. This is great for tests as they can now run in parallel.As a result, adjusted the behaviour of
HTTPAddress()andGRPCAddress()to extract the dynamically assigned port.Related Issue(s)
Follow-up from #9300
How to test
Unit tests
Release Notes
Documentation
NONE