Skip to content

[baseserver] Helper for starting server in tests #9436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

[baseserver] Helper for starting server in tests #9436

merged 1 commit into from
Apr 21, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 20, 2022

Description

Refactor repeated pattern of start and waitToBeReachable in tests into a helper

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested a review from a team April 20, 2022 17:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 20, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 20, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-start-for-tests.1

@easyCZ easyCZ mentioned this pull request Apr 20, 2022
Closed
40 tasks
geropl
geropl approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are running, looks sensible: 👍

@easyCZ
Copy link
Member Author

easyCZ commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-start-for-tests.2

@roboquat roboquat merged commit 11f2180 into main Apr 21, 2022
@roboquat roboquat deleted the mp/baseserver-start-for-tests branch April 21, 2022 07:17
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @geropl @roboquat