Skip to content

[baseserver] Serve pprof on /debug/pprof #9476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 22, 2022

Description

Adds pprof https://pkg.go.dev/net/http/pprof

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested a review from a team April 22, 2022 06:58
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 22, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-pprof.1

andrew-farries
andrew-farries previously approved these changes Apr 22, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2022

@andrew-farries Thanks for the review. Had to rebase so lost the approval :/

andrew-farries
andrew-farries previously approved these changes Apr 22, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2022

/hold

And had to rebase again.. this is getting annoying. Also adding hold to remove it from the merge pool as it's blocking other PRs.

@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-mp-baseserver-pprof.4

@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-pprof.5
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/baseserver-pprof branch from a63dbdd to 1f43c35 Compare April 25, 2022 11:42
@easyCZ
Copy link
Member Author

easyCZ commented Apr 25, 2022

/unhold

@roboquat roboquat merged commit a9ae750 into main Apr 25, 2022
@roboquat roboquat deleted the mp/baseserver-pprof branch April 25, 2022 12:04
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants