Skip to content

Test Delivery for inactive webhook behaves confusing #26824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Young-Lord opened this issue Aug 30, 2023 · 0 comments · Fixed by #27211
Closed

Test Delivery for inactive webhook behaves confusing #26824

Young-Lord opened this issue Aug 30, 2023 · 0 comments · Fixed by #27211
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@Young-Lord
Copy link

Feature Description

Currently, when user click Test Delivery for an inactivate webhook, Gitea will refuse to send the webhook. However, the Response or anywhere else (except log on server) doesn't describe the reason, and may make user think that the webhook server is crashed.
It would be great if a friendly notice was shown in Response column.
see PR #26814

Screenshots

Current behavior

Current page when webhook is inactivate, showing empty Response Headers and Response Body

Expected behavior

Page displayed after this PR, Response Body is set
@Young-Lord Young-Lord added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Aug 30, 2023
@Young-Lord Young-Lord mentioned this issue Aug 30, 2023
Closed
@yardenshoham yardenshoham mentioned this issue Sep 23, 2023
Merged
silverwind pushed a commit that referenced this issue Sep 25, 2023
@yardenshoham
Disable Test Delivery and Replay webhook buttons when webhook is …
e6d8b14 
…inactive (#27211)

These buttons are now disabled when the webhook is not active.

The buttons were always enabled before this change.

- Fixes #26824
- Replaces #26814

# Before


![image](https://github.com/go-gitea/gitea/assets/20454870/e783d0d8-b433-440e-b95f-50d7c42613d3)


![image](https://github.com/go-gitea/gitea/assets/20454870/b4886151-9f32-4e83-8001-dd3f20c23d70)

# After


![image](https://github.com/go-gitea/gitea/assets/20454870/74b76a72-0818-4143-8548-5d42c4119a05)


![image](https://github.com/go-gitea/gitea/assets/20454870/d5ae4e5c-c1ac-4751-a072-e6f7511b1e07)

Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 25, 2023
@yardenshoham @GiteaBot
Disable Test Delivery and Replay webhook buttons when webhook is …
5ad6ec0 
…inactive (go-gitea#27211)

These buttons are now disabled when the webhook is not active.

The buttons were always enabled before this change.

- Fixes go-gitea#26824
- Replaces go-gitea#26814

# Before


![image](https://github.com/go-gitea/gitea/assets/20454870/e783d0d8-b433-440e-b95f-50d7c42613d3)


![image](https://github.com/go-gitea/gitea/assets/20454870/b4886151-9f32-4e83-8001-dd3f20c23d70)

# After


![image](https://github.com/go-gitea/gitea/assets/20454870/74b76a72-0818-4143-8548-5d42c4119a05)


![image](https://github.com/go-gitea/gitea/assets/20454870/d5ae4e5c-c1ac-4751-a072-e6f7511b1e07)

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot mentioned this issue Sep 25, 2023
Merged
lunny pushed a commit that referenced this issue Sep 25, 2023
@GiteaBot @yardenshoham
Disable Test Delivery and Replay webhook buttons when webhook is …
2774a2a 
…inactive (#27211) (#27253)

Backport #27211 by @yardenshoham

These buttons are now disabled when the webhook is not active.

The buttons were always enabled before this change.

- Fixes #26824
- Replaces #26814

# Before


![image](https://github.com/go-gitea/gitea/assets/20454870/e783d0d8-b433-440e-b95f-50d7c42613d3)


![image](https://github.com/go-gitea/gitea/assets/20454870/b4886151-9f32-4e83-8001-dd3f20c23d70)

# After


![image](https://github.com/go-gitea/gitea/assets/20454870/74b76a72-0818-4143-8548-5d42c4119a05)


![image](https://github.com/go-gitea/gitea/assets/20454870/d5ae4e5c-c1ac-4751-a072-e6f7511b1e07)

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Yarden Shoham <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
1 participant
@Young-Lord