-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Make webhook Response Body detailed when webhook is inactive #26814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution, could you create an ISSUE for this pr, for a discussion to take this PR forward |
Thanks for this PR. Instead of adding content to the webhook response body, could you instead:
If you need any help, or pointers on where to start please comment here and we can help out :) |
Sorry, currently I have no time to finish a pr of such scale. The only thing I can do is to post some relative links so that others may implement all these features.
|
One more thing: Can we allow |
…inactive (#27211) These buttons are now disabled when the webhook is not active. The buttons were always enabled before this change. - Fixes #26824 - Replaces #26814 # Before   # After   Signed-off-by: Yarden Shoham <[email protected]>
…inactive (go-gitea#27211) These buttons are now disabled when the webhook is not active. The buttons were always enabled before this change. - Fixes go-gitea#26824 - Replaces go-gitea#26814 # Before   # After   Signed-off-by: Yarden Shoham <[email protected]>
Replaced by #27211 |
…inactive (#27211) (#27253) Backport #27211 by @yardenshoham These buttons are now disabled when the webhook is not active. The buttons were always enabled before this change. - Fixes #26824 - Replaces #26814 # Before   # After   Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: Yarden Shoham <[email protected]>
Currently, when user click
Test Delivery
for an inactivate webhook, Gitea will refuse to send the webhook. However, theResponse
or anywhere else (except log on server) doesn't describe the reason, and may make user think that the webhook server is crashed.This PR writes error message
Hook delivery skipped as webhook is inactive.
to Response Body, so that user can know the status clearly.Comparison
Current behavior
Expected behavior
Closes #26824