Skip to content

[Feature Request] Allow GET comments reactions without token via API #9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
meteorlxy opened this issue Dec 30, 2019 · 1 comment · Fixed by #9548
Closed

[Feature Request] Allow GET comments reactions without token via API #9543

meteorlxy opened this issue Dec 30, 2019 · 1 comment · Fixed by #9548
Labels
type/enhancement An improvement of existing functionality

Comments

@meteorlxy
Copy link

Description

Related to #9220

Currently, we can:

But we can't GET reactions if we don't pass token (get 401):

Hope the behavior of reactions API can be consistent with the former two APIs.

cc @6543
@meteorlxy meteorlxy mentioned this issue Dec 30, 2019
Merged
9 tasks
@6543
Copy link
Member

6543 commented Dec 30, 2019

I'll have a look at it ..
PS: reaction_summary might be helpfull but dont know when this get finished: #9497

@6543 6543 mentioned this issue Dec 30, 2019
Merged
@meteorlxy meteorlxy mentioned this issue Dec 31, 2019
Open
7 tasks
@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 2, 2020
lafriks added a commit that referenced this issue Jan 2, 2020
@6543 @lafriks
[API] dont reqToken on GetReactions (fix #9543) (#9548)
134e3fd 
* dont reqToken on GetReactions

* ctx.Repo.CanWrite has ctx.User.IsAdmin in It

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[API] dont reqToken on GetReactions (fix #9543) 6543-forks/gitea
3 participants
@lunny @meteorlxy @6543