Skip to content

Fix issues/pulls dashboard paging error#10114

Merged
lunny merged 4 commits into
go-gitea:masterfrom
6543-forks:fix-9952
Feb 3, 2020
Merged

Fix issues/pulls dashboard paging error#10114
lunny merged 4 commits into
go-gitea:masterfrom
6543-forks:fix-9952

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Feb 2, 2020

close #9952
(replace) close #9998

credits: @lunny

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 2, 2020

@lunny this code works without the side efect described here: #9998 (review)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 2, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 2, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 2, 2020

@lunny Feel free to change your PR (#9998) and close this one or do it the other way around :)

@lafriks lafriks added this to the 1.12.0 milestone Feb 2, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 2, 2020

since multiselect was introduced in 1.11.0 I think we need a backport

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2020

Codecov Report

Merging #10114 into master will decrease coverage by 0.09%.
The diff coverage is 45.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #10114     +/-   ##
=========================================
- Coverage   43.49%    43.4%   -0.1%     
=========================================
  Files         568      575      +7     
  Lines       79117    79640    +523     
=========================================
+ Hits        34413    34564    +151     
- Misses      40457    40795    +338     
- Partials     4247     4281     +34
Impacted Files Coverage Δ
routers/init.go 65.16% <0%> (-2.65%) ⬇️
modules/queue/queue.go 24.44% <0%> (-2.39%) ⬇️
modules/queue/bytefifo.go 0% <0%> (ø)
modules/queue/queue_redis.go 2.94% <0%> (+1.45%) ⬆️
modules/queue/unique_queue_wrapped.go 1.88% <1.88%> (ø)
modules/queue/setting.go 42.39% <28.12%> (-7.61%) ⬇️
modules/queue/unique_queue_redis.go 3.17% <3.17%> (ø)
modules/setting/queue.go 75.8% <42.85%> (-4.2%) ⬇️
services/pull/check.go 33.33% <47.69%> (-23.32%) ⬇️
modules/queue/unique_queue_disk_channel.go 52.56% <52.56%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd6db2...f4b7e69. Read the comment docs.

@lunny lunny merged commit e959d1a into go-gitea:master Feb 3, 2020
@6543 6543 deleted the fix-9952 branch February 3, 2020 02:22
6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 3, 2020
Co-authored-by: zeripath <art27@cantab.net>
lunny pushed a commit that referenced this pull request Feb 3, 2020
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 3, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Pagination calc on user issue/pull dashborard

7 participants