Skip to content

Fix issues/pulls dashboard paging error#9998

Closed
lunny wants to merge 4 commits into
go-gitea:masterfrom
lunny:lunny/fix_issues_paging
Closed

Fix issues/pulls dashboard paging error#9998
lunny wants to merge 4 commits into
go-gitea:masterfrom
lunny:lunny/fix_issues_paging

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Jan 26, 2020

Fix #9952

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 26, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 26, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
Copy link
Copy Markdown
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solves the one problem but create a new one!!

now if a repo is selected the other repo's are gone (not visilbe to select anymore)

@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 28, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 28, 2020

Codecov Report

Merging #9998 into master will increase coverage by 1.23%.
The diff coverage is 43.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9998      +/-   ##
==========================================
+ Coverage   42.26%   43.49%   +1.23%     
==========================================
  Files         610      567      -43     
  Lines       80392    79109    -1283     
==========================================
+ Hits        33975    34412     +437     
+ Misses      42239    40447    -1792     
- Partials     4178     4250      +72
Impacted Files Coverage Δ
modules/structs/repo.go 36.36% <ø> (ø) ⬆️
routers/api/v1/repo/repo.go 76.22% <ø> (+6.95%) ⬆️
routers/admin/admin.go 10.43% <0%> (-0.77%) ⬇️
routers/repo/setting.go 15.01% <0%> (+0.02%) ⬆️
cmd/manager.go 0% <0%> (ø)
cmd/doctor.go 0% <0%> (ø) ⬆️
routers/private/manager.go 0% <0%> (ø)
modules/graceful/manager_unix.go 40.83% <0%> (-2.53%) ⬇️
routers/repo/milestone.go 0% <0%> (ø) ⬆️
services/pull/review.go 0% <0%> (ø) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661a484...4999feb. Read the comment docs.

@lunny
Copy link
Copy Markdown
Member Author

lunny commented Jan 28, 2020

Don't merge, @6543 I will check that.

6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 2, 2020
@lunny lunny closed this Feb 3, 2020
@lunny lunny deleted the lunny/fix_issues_paging branch February 3, 2020 02:20
lunny pushed a commit that referenced this pull request Feb 3, 2020
Co-authored-by: zeripath <art27@cantab.net>
@lunny lunny removed this from the 1.12.0 milestone Feb 3, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 3, 2020
Co-authored-by: zeripath <art27@cantab.net>
lunny pushed a commit that referenced this pull request Feb 3, 2020
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Pagination calc on user issue/pull dashborard

6 participants