Prevent duplicate records in organizations list when creating a repository

[6543]

prevent double entries in results of GetOrgsCanCreateRepoByUserID

I first try to only add GroupBy directly but xorm return broken user objects ...

... solution was to just query related UserIDs(OrgIDs) first and return OrgUsers based on this IDs

close #11258

[6543]

I think I hit another xorm issue :(

GetOrgsCanCreateRepoByUserID: mssql: Cannot call methods on nvarchar.
GetOrgsCanCreateRepoByUserID: pq: syntax error at or near "."

[zeripath]

How about:

// GetOrgsCanCreateRepoByUserID returns a list of organizations where given user ID
// are allowed to create repos.
func GetOrgsCanCreateRepoByUserID(userID int64) ([]*User, error) {
	orgs := make([]*User, 0, 10)

	return orgs, x.Where("id IN ("+
		"SELECT `user`.id FROM `user` "+
		"INNER JOIN `team_user` ON `team_user`.org_id = `user`.id "+
		"INNER JOIN `team` on `team`.id = `team_user`.team_id "+
		"WHERE `team_user`.uid = ? AND "+
		"(`team`.authorize = ? OR `team`.can_create_org_repo = ?) "+
		"GROUP BY `user`.id)", userID, AccessModeOwner, true).
		Desc("`user`.updated_unix").
		Find(&orgs)
}

---

Fixed some spelling mistakes on my behalf.

[codecov-io]

Codecov Report

Merging #11303 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11303      +/-   ##
==========================================
+ Coverage   43.82%   43.85%   +0.03%     
==========================================
  Files         607      607              
  Lines       86899    86902       +3     
==========================================
+ Hits        38080    38115      +35     
+ Misses      44115    44084      -31     
+ Partials     4704     4703       -1     

Impacted Files	Coverage Δ
models/org.go	70.46% <100.00%> (+0.14%)	⬆️
modules/indexer/stats/queue.go	62.50% <0.00%> (-18.75%)	⬇️
modules/indexer/stats/db.go	40.62% <0.00%> (-9.38%)	⬇️
modules/git/utils.go	65.67% <0.00%> (-4.48%)	⬇️
modules/log/event.go	64.61% <0.00%> (-1.03%)	⬇️
modules/git/repo.go	49.79% <0.00%> (-0.84%)	⬇️
models/issue.go	52.41% <0.00%> (+0.46%)	⬆️
modules/notification/webhook/webhook.go	43.59% <0.00%> (+0.58%)	⬆️
services/mirror/mirror.go	19.40% <0.00%> (+0.65%)	⬆️
routers/repo/view.go	36.82% <0.00%> (+0.67%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0396fcf...25a3e85. Read the comment docs.

[lafriks]

I would prefer that builder would be used to build subselect to be passed to in condition

[6543]

@lafriks done

[6543]

something with the CI unrelated went wrong

[lunny]

Please send back port to v1.11

[6543]

BP now :)

[6543]

-> #11325