Skip to content

Whilst changing the character set to utf8mb4 we should set ROW_FORMAT=dynamic too #12804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeripath merged 5 commits into from
Sep 11, 2020
Merged

Whilst changing the character set to utf8mb4 we should set ROW_FORMAT=dynamic too #12804

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ddd271
Whilst changing the character set to utf8mb4 we should set ROW_FORMAT…
zeripath Sep 10, 2020
2af5893
Merge branch 'master' into fix-12801-make-convert-do-row-format-dynamic
lunny Sep 10, 2020
0b83823
Merge branch 'master' into fix-12801-make-convert-do-row-format-dynamic
zeripath Sep 11, 2020
f8d0610
Merge branch 'master' into fix-12801-make-convert-do-row-format-dynamic
zeripath Sep 11, 2020
30db918
Merge branch 'master' into fix-12801-make-convert-do-row-format-dynamic
zeripath Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion models/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"code.gitea.io/gitea/modules/setting"
)

// ConvertUtf8ToUtf8mb4 converts database and tables from utf8 to utf8mb4 if it's mysql
// ConvertUtf8ToUtf8mb4 converts database and tables from utf8 to utf8mb4 if it's mysql and set ROW_FORMAT=dynamic
func ConvertUtf8ToUtf8mb4() error {
_, err := x.Exec(fmt.Sprintf("ALTER DATABASE `%s` CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci", setting.Database.Name))
if err != nil {
Expand All @@ -22,6 +22,10 @@ func ConvertUtf8ToUtf8mb4() error {
return err
}
for _, table := range tables {
if _, err := x.Exec(fmt.Sprintf("ALTER TABLE `%s` ROW_FORMAT=dynamic;", table.Name)); err != nil {
return err
}

if _, err := x.Exec(fmt.Sprintf("ALTER TABLE `%s` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;", table.Name)); err != nil {
return err
}
Expand Down