Whilst changing the character set to utf8mb4 we should set ROW_FORMAT=dynamic too#12804
Merged
zeripath merged 5 commits intoSep 11, 2020
Conversation
…=dynamic too Fix go-gitea#12801 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12804 +/- ##
=======================================
Coverage 43.16% 43.16%
=======================================
Files 651 651
Lines 72136 72138 +2
=======================================
+ Hits 31137 31139 +2
- Misses 35944 35946 +2
+ Partials 5055 5053 -2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Sep 10, 2020
GiteaBot
added
lgtm/need 1
mrsdizzie
approved these changes
Sep 10, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Sep 10, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12801
Signed-off-by: Andrew Thornton art27@cantab.net