Slightly simplify the queue settings code to help reduce the risk of problems#12976
Merged
techknowlogick merged 2 commits intoOct 15, 2020
Merged
Conversation
…problems Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/refactoring
Codecov Report
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 42.60% 42.56% -0.04%
==========================================
Files 671 671
Lines 73627 73620 -7
==========================================
- Hits 31368 31338 -30
- Misses 37179 37194 +15
- Partials 5080 5088 +8
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Sep 29, 2020
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
Interesting code comments - like them :)
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Oct 15, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
+ Coverage 42.05% 42.07% +0.01%
==========================================
Files 681 681
Lines 75121 75114 -7
==========================================
+ Hits 31594 31606 +12
+ Misses 38372 38354 -18
+ Partials 5155 5154 -1
Continue to review full report at Codecov.
|
ivanvc
added a commit
to ivanvc/gitea
that referenced
this pull request
Oct 16, 2020
…ments-in-pull-request-label-style * origin/master: [skip ci] Updated translations via Crowdin Fix diff skipping lines (go-gitea#13154) Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169) Vendor Update Go Libs (go-gitea#13166) Prevent panics with missing storage (go-gitea#13164) Improve users management through the CLI (go-gitea#6001) (go-gitea#10492) Change order of possible-owner organizations to alphabetical (go-gitea#13160) Slightly simplify the queue settings code to help reduce the risk of problems (go-gitea#12976) [Vendor] Update go-ldap to v3.2.4 (go-gitea#13163) [skip ci] Updated translations via Crowdin Update external-renderers.en-us.md (go-gitea#13165)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent bug occurred due to a gotcha in the settings code for queues. This code used to do an unnecessary struct to map[string]interface{} conversion that with a small amount renaming is removable.
There a few changes in the helper.go:toConfig() function which allow for more options in future.
Signed-off-by: Andrew Thornton art27@cantab.net