[Vendor] Update go-ldap to v3.2.4#13163
Merged
Merged
Conversation
techknowlogick
added
the
skip-changelog
Member
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
Because it is v3 you'll need to reference github.com/go-ldap/ldap/v3
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #13163 +/- ##
==========================================
- Coverage 42.08% 41.94% -0.15%
==========================================
Files 681 681
Lines 75121 75121
==========================================
- Hits 31613 31506 -107
- Misses 38357 38492 +135
+ Partials 5151 5123 -28
Continue to review full report at Codecov.
|
6543
changed the title
Member
Author
|
@techknowlogick somehow missed that ... now it works as it should :) |
zeripath
reviewed
Oct 15, 2020
zeripath
approved these changes
Oct 15, 2020
GiteaBot
added
lgtm/need 1
Member
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
somehow missed that ...
no worries. I just made this same upgrade in another project so I was recently aware of it.
techknowlogick
approved these changes
Oct 15, 2020
GiteaBot
added
lgtm/done
ivanvc
added a commit
to ivanvc/gitea
that referenced
this pull request
Oct 16, 2020
…ments-in-pull-request-label-style * origin/master: [skip ci] Updated translations via Crowdin Fix diff skipping lines (go-gitea#13154) Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169) Vendor Update Go Libs (go-gitea#13166) Prevent panics with missing storage (go-gitea#13164) Improve users management through the CLI (go-gitea#6001) (go-gitea#10492) Change order of possible-owner organizations to alphabetical (go-gitea#13160) Slightly simplify the queue settings code to help reduce the risk of problems (go-gitea#12976) [Vendor] Update go-ldap to v3.2.4 (go-gitea#13163) [skip ci] Updated translations via Crowdin Update external-renderers.en-us.md (go-gitea#13165)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go get -uhad an issue with it, this fix it :)