Skip to content

Only log Error on getLastCommitStatus error to let pull list still be visible#15716

Merged
6543 merged 2 commits into
go-gitea:masterfrom
6543-forks:pull-list_skip-lastCommitStatus-if-err_master
May 4, 2021
Merged

Only log Error on getLastCommitStatus error to let pull list still be visible#15716
6543 merged 2 commits into
go-gitea:masterfrom
6543-forks:pull-list_skip-lastCommitStatus-if-err_master

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented May 4, 2021

as title

@6543 6543 added the type/bug label May 4, 2021
@6543 6543 added this to the 1.15.0 milestone May 4, 2021
@6543 6543 added backport/done All backports for this PR have been created backport/v1.14 labels May 4, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #15716 (8a28f29) into master (5c5cfd6) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15716      +/-   ##
==========================================
- Coverage   43.89%   43.88%   -0.01%     
==========================================
  Files         678      678              
  Lines       81868    81878      +10     
==========================================
+ Hits        35933    35936       +3     
- Misses      40086    40093       +7     
  Partials     5849     5849              
Impacted Files Coverage Δ
modules/nosql/manager_redis.go 0.00% <0.00%> (ø)
services/pull/pull.go 43.83% <0.00%> (-0.11%) ⬇️
routers/repo/release.go 24.39% <66.66%> (+1.19%) ⬆️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
routers/repo/view.go 40.66% <0.00%> (-0.59%) ⬇️
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e047b9...8a28f29. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2021
@6543 6543 merged commit 1cd3017 into go-gitea:master May 4, 2021
@6543 6543 deleted the pull-list_skip-lastCommitStatus-if-err_master branch May 4, 2021 12:03
@zeripath zeripath mentioned this pull request May 8, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants