Fix middleware function's placements#19377
Merged
Merged
Conversation
- Add reqSignIn to `/task/{task}` as it specific to a logged in user
currently not-logged in user could cause a NPE.
- Move `/stopwatch` & `/search` middleware before the actual function is
called, because functions are executed in order and currently hadn't
any effect and could as well cause a NPE due to that.
- Remove `/active` reqSignIn middleware, because when you want to active
a account you're not "signed in" so it doesn't make sense to add that
middleware.
Gusted
added
type/enhancement
delvh
approved these changes
Apr 11, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Apr 11, 2022
- Backport go-gitea#19377 - Add reqSignIn to `/task/{task}` as it specific to a logged in user currently not-logged in user could cause a NPE. - Remove `/active` reqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.
Codecov Report
@@ Coverage Diff @@
## main #19377 +/- ##
=======================================
Coverage ? 47.39%
=======================================
Files ? 949
Lines ? 132090
Branches ? 0
=======================================
Hits ? 62605
Misses ? 61952
Partials ? 7533
Continue to review full report at Codecov.
|
wxiaoguang
approved these changes
Apr 12, 2022
GiteaBot
added
lgtm/done
wxiaoguang
added
the
skip-changelog
wxiaoguang
pushed a commit
that referenced
this pull request
Apr 12, 2022
- Backport #19377 - Add reqSignIn to `/user/task/{task}` as it specific to a logged in user currently not-logged in user could cause a NPE. - Remove `/user/active` reqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 12, 2022
* giteaoffical/main: Document 409 error returned by repos/migrate api (go-gitea#19376) Fix middleware function's placements for some `/user/...` (go-gitea#19377) Fix panic in teams API when requesting members (go-gitea#19360)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
…9377) - Add reqSignIn to `/user/task/{task}` as it specific to a logged in user currently not-logged in user could cause a NPE. - Move `/user/stopwatch` & `/user/search` middleware before the actual function is called, because functions are executed in order and currently hadn't any effect and could as well cause a NPE due to that. - Remove `/user/active` reqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/task/{task}as it specific to a logged in user currently not-logged in user could cause a NPE./stopwatch&/searchmiddleware before the actual function is called, because functions are executed in order and currently hadn't any effect and could as well cause a NPE due to that./activereqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.