Fix middleware function's placements (#19377)#19378
Merged
wxiaoguang merged 1 commit intoApr 12, 2022
Merged
Conversation
- Backport go-gitea#19377 - Add reqSignIn to `/task/{task}` as it specific to a logged in user currently not-logged in user could cause a NPE. - Remove `/active` reqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.
delvh
approved these changes
Apr 11, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Apr 12, 2022
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/task/{task}as it specific to a logged in user currently not-logged in user could cause a NPE./activereqSignIn middleware, because when you want to active a account you're not "signed in" so it doesn't make sense to add that middleware.