Use a better OlderThan for DeleteInactiveUsers#19693
Merged
Merged
Conversation
- Currently the OlderThan is zero, for instances that enable or run this task this could actually delete just new users that still need to confirm their email. This patch fixes that by setting the default to the `ActiveCodeLives` setting, which corresponds to the amount of time that a user can active their account, thus avoiding the issue of deleting unactivated email users.
techknowlogick
added
the
type/enhancement
6543
approved these changes
May 12, 2022
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
May 12, 2022
Member
|
lunny
approved these changes
May 13, 2022
GiteaBot
added
lgtm/done
Member
|
. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 13, 2022
* giteaofficial/main: Use a better OlderThan for DeleteInactiveUsers (go-gitea#19693) [skip ci] Updated translations via Crowdin Introduce eslint-plugin-jquery (go-gitea#19690)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Use a better OlderThan for DeleteInactiveUsers - Currently the OlderThan is zero, for instances that enable or run this task this could actually delete just new users that still need to confirm their email. This patch fixes that by setting the default to the `ActiveCodeLives` setting, which corresponds to the amount of time that a user can active their account, thus avoiding the issue of deleting unactivated email users. * Use correct duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveCodeLivessetting, which corresponds to the amount of time that a user can active their account via email and thus avoiding the issue of deleting 'legit' unactivated users.