Skip to content

Use a better OlderThan for DeleteInactiveUsers #19693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 3 commits into from
May 13, 2022
Merged

Use a better OlderThan for DeleteInactiveUsers #19693

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89d32ec
Use a better OlderThan for DeleteInactiveUsers
May 12, 2022
c19d576
Use correct duration
May 12, 2022
86ed365
Merge branch 'main' into use-sane-default-olderthan
lunny May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/cron/tasks_extended.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func registerDeleteInactiveUsers() {
RunAtStart: false,
Schedule: "@annually",
},
OlderThan: 0 * time.Second,
OlderThan: time.Minute * time.Duration(setting.Service.ActiveCodeLives),
}, func(ctx context.Context, _ *user_model.User, config Config) error {
olderThanConfig := config.(*OlderThanConfig)
return user_service.DeleteInactiveUsers(ctx, olderThanConfig.OlderThan)
Expand Down