Make notification bell more prominent on mobile by tyroneyeh · Pull Request #20108 · go-gitea/gitea

tyroneyeh · 2022-06-23T14:52:53Z

Closes #20069

…sition with mobile

tyroneyeh · 2022-06-24T00:25:31Z

Results:

lunny · 2022-06-24T02:31:57Z

So for non-login, it's a blank in the right-top corner.

tyroneyeh · 2022-06-24T02:40:30Z

non-login is display this

wxiaoguang · 2022-06-24T03:13:26Z

IMO there might be an easier solution. Keep the layout as much as possible, just move the bell(notification) element out from the right stackable menu and put the bell alongside the menu. The benefit is that there will be still only one bell element, instead of two copied, which is not easy to be maintained in the future. Just a guess, haven't tried yet.

Hmm ... it seems not feasible. The mobile layout and desktop layout is different.

lunny · 2022-06-24T03:16:41Z

How about put the smallbell middle?

tyroneyeh · 2022-06-24T03:28:58Z

How about put the smallbell middle?

like this？

wxiaoguang · 2022-06-24T03:57:45Z

like this？

Looks fine to me. Or make the bell right-aligned(beside the menu), either is fine to me.

codecov-commenter · 2022-06-24T04:35:16Z

Codecov Report

❗ No coverage uploaded for pull request base (main@d0507ef). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #20108   +/-   ##
=======================================
  Coverage        ?   46.94%           
=======================================
  Files           ?      972           
  Lines           ?   134536           
  Branches        ?        0           
=======================================
  Hits            ?    63164           
  Misses          ?    63630           
  Partials        ?     7742

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0507ef...9849c91. Read the comment docs.

…lines

tyroneyeh · 2022-07-04T09:14:03Z

conflict ?

lunny · 2022-07-04T09:32:19Z

conflict ?

Yes, please resolve the conflicts.

tyroneyeh · 2022-07-04T11:10:14Z

conflict ?

Yes, please resolve the conflicts.

Solved

lunny · 2022-07-04T14:44:26Z

LGTM

…itea#20236, go-gitea#20251) Backport go-gitea#20108 Backport go-gitea#20236 Backport go-gitea#20251 Make notification bell more prominent on mobile Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Tyrone Yeh <siryeh@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net>

Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <art27@cantab.net>

Unfortunately there is a bug in #20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <art27@cantab.net>

* upstream/main: Modify milestone search keywords to be case insensitive (go-gitea#20266) Fix toolip on mobile notification bell (go-gitea#20270) Allow RSA 2047 bit keys (go-gitea#20272) Refix notification bell placement (go-gitea#20251) Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256) EscapeFilter the group dn membership (go-gitea#20200) Only show Followers that current user can access (go-gitea#20220) Init popup for new code comment (go-gitea#20234) Bypass Firefox (iOS) bug (go-gitea#20244) Adjust max-widths for the repository file table (go-gitea#20243) Display full name (go-gitea#20171) Adjust class for mobile has the problem of double small bells (go-gitea#20236) Adjust template for go-gitea#20069 smallbell (go-gitea#20108) Add integration tests for the Gitea migration form (go-gitea#20121) Allow dev i18n to be more concurrent (go-gitea#20159) Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)

…) (#20269) Backport #20108 Backport #20236 Backport #20251 Make notification bell more prominent on mobile Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Tyrone Yeh <siryeh@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net>

* Adjust template for go-gitea#20069 smallbell * Adjust notification Unread Count variable to global and count bell position with mobile * Adjust bell icon style * Adjust smallbell to middle * Avoid using inline styles * move notificationUnreadCount to a general code block, reduce changed lines * Solved conflicts Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>

Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <art27@cantab.net>

- Since go-gitea#20108 we have two version of the notification bell, one for mobile the other for non-mobile. However the code only accounts for one notification count and thus was only updating the non-mobile one. - This code fixes that by applying the code for all `.notification_count`s. - Frontport will be in go-gitea#20543

- Since #20108 we have two version of the notification bell, one for mobile the other for non-mobile. However the code only accounts for one notification count and thus was only updating the non-mobile one. - This code fixes that by applying the code for all `.notification_count`s. - Frontport will be in #20543

* Adjust template for go-gitea#20069 smallbell * Adjust notification Unread Count variable to global and count bell position with mobile * Adjust bell icon style * Adjust smallbell to middle * Avoid using inline styles * move notificationUnreadCount to a general code block, reduce changed lines * Solved conflicts Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>

Unfortunately there is a bug in go-gitea#20108 where the translation call was not updated to use `.locale` from `.i18n`. This PR updates the template to use `.locale`. Signed-off-by: Andrew Thornton <art27@cantab.net>

Adjust template for #20069 smallbell

8accfa6

zeripath reviewed Jun 23, 2022

View reviewed changes

Comment thread templates/base/head_navbar.tmpl Outdated

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 23, 2022

tyroneyeh added 2 commits June 24, 2022 07:58

Adjust notification Unread Count variable to global and count bell po…

368fb00

…sition with mobile

Adjust bell icon style

ebf1081

lunny added the topic/ui Change the appearance of the Gitea UI label Jun 24, 2022

lunny added this to the 1.18.0 milestone Jun 24, 2022

Adjust smallbell to middle

9849c91

Gusted reviewed Jun 24, 2022

View reviewed changes

Comment thread templates/base/head_navbar.tmpl Outdated

Comment thread templates/base/head_navbar.tmpl Outdated

Avoid using inline styles

7ae1afd

Gusted approved these changes Jun 25, 2022

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 25, 2022

move notificationUnreadCount to a general code block, reduce changed …

20d9195

…lines

wxiaoguang approved these changes Jun 25, 2022

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2022

Merge branch 'main' into 20069_smallbell_for_mobile

18f6e8e

Gusted approved these changes Jun 26, 2022

View reviewed changes

Merge branch 'main' into 20069_smallbell_for_mobile

124e478

tyroneyeh and others added 3 commits July 4, 2022 18:06

Solved conflicts

6fc1ede

Merge branch 'main' into 20069_smallbell_for_mobile

5f700d5

Merge branch 'main' into 20069_smallbell_for_mobile

eb4f475

Merge branch 'main' into 20069_smallbell_for_mobile

7c76da6

lunny merged commit c174bdc into go-gitea:main Jul 4, 2022

zeripath mentioned this pull request Jul 5, 2022

Adjust class for mobile has the problem of double small bells #20236

Merged

zeripath changed the title ~~Adjust template for #20069 smallbell~~ Make notification bell more prominent on mobile Jul 6, 2022

zeripath mentioned this pull request Jul 6, 2022

Make notification bell more prominent on mobile (#20108, #20236, #20251) #20269

Merged

zeripath mentioned this pull request Jul 6, 2022

Fix toolip on mobile notification bell #20270

Merged

6543 added backport/done All backports for this PR have been created backport/v1.17 labels Jul 7, 2022

tyroneyeh deleted the 20069_smallbell_for_mobile branch July 17, 2022 14:43

Gusted mentioned this pull request Jul 29, 2022

Update notification count for non-mobile version #20544

Merged

go-gitea locked and limited conversation to collaborators May 3, 2023

Uh oh!

Conversation

tyroneyeh commented Jun 23, 2022

Uh oh!

Uh oh!

tyroneyeh commented Jun 24, 2022

Uh oh!

lunny commented Jun 24, 2022

Uh oh!

tyroneyeh commented Jun 24, 2022

Uh oh!

wxiaoguang commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lunny commented Jun 24, 2022

Uh oh!

tyroneyeh commented Jun 24, 2022

Uh oh!

wxiaoguang commented Jun 24, 2022

Uh oh!

codecov-commenter commented Jun 24, 2022

Codecov Report

Uh oh!

Uh oh!

Uh oh!

tyroneyeh commented Jul 4, 2022

Uh oh!

lunny commented Jul 4, 2022

Uh oh!

tyroneyeh commented Jul 4, 2022

Uh oh!

lunny commented Jul 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wxiaoguang commented Jun 24, 2022 •

edited

Loading