Refix notification bell placement#20251
Merged
Merged
Conversation
The use of `m-4 text black` for the notification bell results in this icon being shifted upwards. Instead we should use the `item` class but adjust `not-mobile` and `mobile-only` to make their `display: none` settings `!important`. (As an aside: This is probably one of the only times we should use `!important` in our less files and the rest should be avoided or removed.) Ref go-gitea#20069 Revert go-gitea#20236 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
topic/ui
Contributor
Author
|
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf Does this work for you? |
GiteaBot
added
the
lgtm/need 2
Contributor
|
Looks like it should be fine, thanks |
Contributor
let me do a clean rebuild after applying the patch. this should then also fix #20245. EDIT: works fine on my instance! 🚀 |
Contributor
Author
|
Yeah sorry I forgot you'd opened a bug from the comment! |
Contributor
Author
|
I suspect that the |
Contributor
np, thanks for the fix.
it always does :D |
Contributor
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
left a comment
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
left a comment
There was a problem hiding this comment.
works well, I'd officially approve if I could (apparently only maintainers can do that now)...
lunny
approved these changes
Jul 5, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jul 6, 2022
Member
delvh
left a comment
delvh
left a comment
There was a problem hiding this comment.
works well, I'd officially approve if I could (apparently only maintainers can do that now)...
I'll do it for you :)
GiteaBot
added
lgtm/done
Contributor
Author
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jul 6, 2022
…itea#20236, go-gitea#20251) Backport go-gitea#20108 Backport go-gitea#20236 Backport go-gitea#20251 Make notification bell more prominent on mobile Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Tyrone Yeh <siryeh@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net>
Member
|
LGTM |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 7, 2022
* upstream/main: Modify milestone search keywords to be case insensitive (go-gitea#20266) Fix toolip on mobile notification bell (go-gitea#20270) Allow RSA 2047 bit keys (go-gitea#20272) Refix notification bell placement (go-gitea#20251) Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256) EscapeFilter the group dn membership (go-gitea#20200) Only show Followers that current user can access (go-gitea#20220) Init popup for new code comment (go-gitea#20234) Bypass Firefox (iOS) bug (go-gitea#20244) Adjust max-widths for the repository file table (go-gitea#20243) Display full name (go-gitea#20171) Adjust class for mobile has the problem of double small bells (go-gitea#20236) Adjust template for go-gitea#20069 smallbell (go-gitea#20108) Add integration tests for the Gitea migration form (go-gitea#20121) Allow dev i18n to be more concurrent (go-gitea#20159) Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
dineshsalunke
pushed a commit
to dineshsalunke/gitea
that referenced
this pull request
Jul 9, 2022
The use of `m-4 text black` for the notification bell results in this icon being shifted upwards. Instead we should use the `item` class but adjust `not-mobile` and `mobile-only` to make their `display: none` settings `!important`. (As an aside: This is probably one of the only times we should use `!important` in our less files and the rest should be avoided or removed.) Ref go-gitea#20069 Revert go-gitea#20236 Signed-off-by: Andrew Thornton <art27@cantab.net>
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
The use of `m-4 text black` for the notification bell results in this icon being shifted upwards. Instead we should use the `item` class but adjust `not-mobile` and `mobile-only` to make their `display: none` settings `!important`. (As an aside: This is probably one of the only times we should use `!important` in our less files and the rest should be avoided or removed.) Ref go-gitea#20069 Revert go-gitea#20236 Signed-off-by: Andrew Thornton <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of
m-4 text blackfor the notification bell results in thisicon being shifted upwards. Instead we should use the
itemclass butadjust
not-mobileandmobile-onlyto make theirdisplay: nonesettings
!important.(As an aside: This is probably one of the only times we should use
!importantin our less files and the rest should be avoided orremoved.)
Ref #20069
Revert #20236
Fix #20245
Signed-off-by: Andrew Thornton art27@cantab.net