Skip to content

Improve dropdown button alignment and fix hover bug #27632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wxiaoguang merged 2 commits into from
Oct 16, 2023
Merged

Improve dropdown button alignment and fix hover bug #27632

wxiaoguang merged 2 commits into from
Oct 16, 2023

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 15, 2023

  1. fix Options button in the commit view is taller than Browse Source #27631 , and add samples to devtest page
  2. fix incorrect color for "ui dropdown button" when hover

Before:

image

After:

image

@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Oct 15, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2023
@wxiaoguang wxiaoguang mentioned this pull request Oct 15, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 16, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 16, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 16, 2023 06:51
@wxiaoguang wxiaoguang merged commit 6c501b1 into go-gitea:main Oct 16, 2023
@GiteaBot GiteaBot mentioned this pull request Oct 16, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 16, 2023
@wxiaoguang @GiteaBot
Improve dropdown button alignment and fix hover bug (go-gitea#27632)
35cec7a 
1. fix go-gitea#27631 , and add samples to devtest page
2. fix incorrect color for "ui dropdown button" when hover
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 16, 2023
wxiaoguang added a commit that referenced this pull request Oct 16, 2023
@GiteaBot @wxiaoguang
Improve dropdown button alignment and fix hover bug (#27632) (#27637)
21c3513 
Backport #27632 by @wxiaoguang

1. fix #27631 , and add samples to devtest page
2. fix incorrect color for "ui dropdown button" when hover

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 17, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ac6db5e 
* giteaofficial/main:
  cleanup repo details icons/labels (go-gitea#27644)
  Improve dropdown button alignment and fix hover bug (go-gitea#27632)
@wxiaoguang wxiaoguang deleted the fix-dropdown branch October 22, 2023 13:44
@silverwind silverwind mentioned this pull request Oct 23, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@lng2020 lng2020 lng2020 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

Options button in the commit view is taller than Browse Source

4 participants

@wxiaoguang @lunny @lng2020 @GiteaBot