cleanup repo details icons/labels #27644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
denyskon
added
backport/v1.21
delvh
approved these changes
Oct 16, 2023
GiteaBot
added
lgtm/need 1
lng2020
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Thanks for your implementation. That's really fast. Since I proposed this design, It seems not appropriate for me to approve.
This PR is LGTM, but It would be nice if the repo_list.tmpl moved to a common folder instead of explore since it's used by many other templates.
Share some screenshots for this PR so other reviewers can better review it.
Looks nice too in a mobile view
6543
approved these changes
Oct 16, 2023
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 16, 2023
Fix go-gitea#27596 Change confusing behavior when showing information about a repo via labels and icons. Implement changes proposed by @lng2020 in go-gitea#27627 (review).
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 17, 2023
* giteaofficial/main: cleanup repo details icons/labels (go-gitea#27644) Improve dropdown button alignment and fix hover bug (go-gitea#27632)
delvh
pushed a commit
that referenced
this pull request
Oct 19, 2023
Backport #27644 by @denyskon Fix #27596 Change confusing behavior when showing information about a repo via labels and icons. Implement changes proposed by @lng2020 in #27627 (review). Co-authored-by: Denys Konovalov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27596
Change confusing behavior when showing information about a repo via labels and icons. Implement changes proposed by @lng2020 in #27627 (review).