Ignore temporary files for directory size #28265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- While looking trough the logs for unrelated things I noticed errors for directory size calculations in `pushUpdates` that were being caused by a race condition in which git was making temporary file, `filepath.WalkDir` noticed that but by the time the second lstat came(`info.Info()`) it was already gone and it would error. - Ignore temporary files created by Git. - There are other cases but much much more rarer and not trivial to detect. Examples: ...s/repository/push.go:96:pushUpdates() [E] Failed to update size for repository: updateSize: lstat [...]/objects/info/commit-graphs/tmp_graph_Wcy9kR: no such file or directory ...s/repository/push.go:96:pushUpdates() [E] Failed to update size for repository: updateSize: lstat [...]/packed-refs.lock: no such file or directory Refs: https://codeberg.org/forgejo/forgejo/pulls/1748 (cherry picked from commit c3aebcf16a7181192432730b827e369728196968)
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Nov 28, 2023
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Nov 28, 2023
GiteaBot
added
lgtm/done
jolheiser
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
This fix is not right. |
|
-> Ignore "non-existing" errors when getDirectorySize calculates the size #28276 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 29, 2023
* giteaofficial/main: Fix required error for token name (go-gitea#28267) Use appSubUrl for OAuth2 callback URL tip (go-gitea#28266) Ignore temporary files for directory size (go-gitea#28265) Check for v prefix on tags for release clean name (go-gitea#28257)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Co-authored-by: Gusted <[email protected]>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Gusted <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushUpdatesthat were being caused by a race condition in which git was making temporary file,filepath.WalkDirnoticed that but by the time the second lstat came(info.Info()) it was already gone and it would error.Examples:
...s/repository/push.go:96:pushUpdates() [E] Failed to update size for repository: updateSize: lstat [...]/objects/info/commit-graphs/tmp_graph_Wcy9kR: no such file or directory
...s/repository/push.go:96:pushUpdates() [E] Failed to update size for repository: updateSize: lstat [...]/packed-refs.lock: no such file or directory
Refs: https://codeberg.org/forgejo/forgejo/pulls/1748
(cherry picked from commit c3aebcf16a7181192432730b827e369728196968)