-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Check for v prefix on tags for release clean name #28257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
Nov 28, 2023
delvh
reviewed
Nov 28, 2023
lunny
approved these changes
Nov 28, 2023
delvh
approved these changes
Nov 28, 2023
I was unable to create a backport for 1.20. @jolheiser, please send one manually. 🍵
|
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 28, 2023
jolheiser
added a commit
that referenced
this pull request
Nov 28, 2023
Co-authored-by: John Olheiser <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Nov 28, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 29, 2023
* giteaofficial/main: Fix required error for token name (go-gitea#28267) Use appSubUrl for OAuth2 callback URL tip (go-gitea#28266) Ignore temporary files for directory size (go-gitea#28265) Check for v prefix on tags for release clean name (go-gitea#28257)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/manual
No power to the bots! Create your backport yourself!
backport/v1.20
This PR should be backported to Gitea 1.20
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/internal
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, this will strip the
v
prefix when getting a "clean" name for a tag.From the last run:
https://github.com/go-gitea/gitea/actions/runs/7015365494/job/19084572109
REF_NAME=$(echo "refs/tags/v1.20.6" | sed -e 's/refs\/heads\///' -e 's/refs\/tags\///' -e 's/release\/v//')
It strips
ref/tags/
and just needs to strip the additionalv
.