Skip to content

Check for v prefix on tags for release clean name #28257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jolheiser
Copy link
Member

As title, this will strip the v prefix when getting a "clean" name for a tag.

From the last run:
https://github.com/go-gitea/gitea/actions/runs/7015365494/job/19084572109
REF_NAME=$(echo "refs/tags/v1.20.6" | sed -e 's/refs\/heads\///' -e 's/refs\/tags\///' -e 's/release\/v//')
It strips ref/tags/ and just needs to strip the additional v.

@jolheiser jolheiser added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2023
@techknowlogick techknowlogick added the backport/v1.20 This PR should be backported to Gitea 1.20 label Nov 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2023
@jolheiser jolheiser merged commit 05b8023 into go-gitea:main Nov 28, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 28, 2023
@jolheiser jolheiser deleted the release-clean-branch branch November 28, 2023 21:18
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.20. @jolheiser, please send one manually. 🍵

go run ./contrib/backport 28257
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 28, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 28, 2023
jolheiser added a commit that referenced this pull request Nov 28, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 29, 2023
* giteaofficial/main:
  Fix required error for token name (go-gitea#28267)
  Use appSubUrl for OAuth2 callback URL tip (go-gitea#28266)
  Ignore temporary files for directory size (go-gitea#28265)
  Check for v prefix on tags for release clean name (go-gitea#28257)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny lunny added the backport/done All backports for this PR have been created label Feb 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants