Skip to content

Check for v prefix on tags for release clean name (#28257) #28270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #28257 by @jolheiser

As title, this will strip the v prefix when getting a "clean" name for a tag.

From the last run:
https://github.com/go-gitea/gitea/actions/runs/7015365494/job/19084572109
REF_NAME=$(echo "refs/tags/v1.20.6" | sed -e 's/refs\/heads\///' -e 's/refs\/tags\///' -e 's/release\/v//')
It strips ref/tags/ and just needs to strip the additional v.

@GiteaBot GiteaBot added modifies/internal topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Nov 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2023
@GiteaBot GiteaBot added this to the 1.21.2 milestone Nov 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2023
@jolheiser jolheiser merged commit 5001f63 into go-gitea:release/v1.21 Nov 28, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants