Skip to content

webhook tag sha fix (#286)#300

Merged
bkcsoft merged 4 commits into
masterfrom
bkcsoft/webhook-tag-sha-fix
Nov 29, 2016
Merged

webhook tag sha fix (#286)#300
bkcsoft merged 4 commits into
masterfrom
bkcsoft/webhook-tag-sha-fix

Conversation

@bkcsoft
Copy link
Copy Markdown
Contributor

@bkcsoft bkcsoft commented Nov 29, 2016

Fixes #286
Depends on go-gitea/go-sdk#21 (Don't merge before I've vendored it!)

Tag-hooks are pretty useless without specifying which shasum the new tag points at, this PR fixes that :)

Question: Should we also send the Shasum for "create branch"-events? (need to add another line in that case ^.^ ) Yes

@bkcsoft bkcsoft added this to the 1.0.0 milestone Nov 29, 2016
@strk
Copy link
Copy Markdown
Member

strk commented Nov 29, 2016

Why not ?
LGTM, but I guess you'll need to also add the vendor/ update once upstream is fixed (before merging this)

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 29, 2016
@bkcsoft
Copy link
Copy Markdown
Contributor Author

bkcsoft commented Nov 29, 2016

@strk Not sure if we need it for new branches? and yes, need to vendor, but waiting for dep to be merged first :)

@lunny
Copy link
Copy Markdown
Member

lunny commented Nov 29, 2016

ci failed. and it seems your code is not the latest master.

@tboerger
Copy link
Copy Markdown
Member

Just bump it with a comment when everything is done.

@tboerger tboerger added the pr/wip This PR is not ready for review label Nov 29, 2016
@bkcsoft
Copy link
Copy Markdown
Contributor Author

bkcsoft commented Nov 29, 2016

@tboerger @lunny done :)

@bkcsoft bkcsoft force-pushed the bkcsoft/webhook-tag-sha-fix branch from ac3a599 to d7bfc3c Compare November 29, 2016 08:26
@bkcsoft bkcsoft removed the pr/wip This PR is not ready for review label Nov 29, 2016
@tboerger
Copy link
Copy Markdown
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2016
@bkcsoft bkcsoft merged commit 42ec5ce into master Nov 29, 2016
@bkcsoft bkcsoft deleted the bkcsoft/webhook-tag-sha-fix branch November 29, 2016 10:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add commit sha to create tag webhook payload

4 participants