Skip to content
This repository was archived by the owner on Jun 8, 2019. It is now read-only.

webhook tag sha fix#21

Merged
lunny merged 1 commit into
masterfrom
bkcsoft/webhook-tag-sha-fix
Nov 29, 2016
Merged

webhook tag sha fix#21
lunny merged 1 commit into
masterfrom
bkcsoft/webhook-tag-sha-fix

Conversation

@bkcsoft
Copy link
Copy Markdown

@bkcsoft bkcsoft commented Nov 29, 2016

@strk
Copy link
Copy Markdown
Member

strk commented Nov 29, 2016

LGTM

@tboerger
Copy link
Copy Markdown
Member

Shouldn't that be SHA?

@tboerger
Copy link
Copy Markdown
Member

But you still get my LGTM

@lunny
Copy link
Copy Markdown
Member

lunny commented Nov 29, 2016

@tboerger golint PASS :)

@lunny lunny merged commit 140df7f into master Nov 29, 2016
@tboerger tboerger deleted the bkcsoft/webhook-tag-sha-fix branch November 29, 2016 07:38
@bkcsoft
Copy link
Copy Markdown
Author

bkcsoft commented Nov 29, 2016

@tboerger It should indeed be SHA 😆

@lunny
Copy link
Copy Markdown
Member

lunny commented Nov 29, 2016

@bkcsoft You can send another PR. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants