Skip to content

Refactor AppURL usage#30885

Merged
wxiaoguang merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-app-url
May 7, 2024
Merged

Refactor AppURL usage#30885
wxiaoguang merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-app-url

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented May 7, 2024

Fix #30883
Fix #29591

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2024
This was referenced May 7, 2024
Closed
Closed
KN4CK3R
KN4CK3R reviewed May 7, 2024
View reviewed changes
Comment thread modules/httplib/url.go
@lunny
Copy link
Copy Markdown
Member

lunny commented May 7, 2024

Maybe we should update the nginx and other reverse proxy documentation to ask a header, otherwise some of them may not work.

@wxiaoguang
Copy link
Copy Markdown
Contributor Author

wxiaoguang commented May 7, 2024

Maybe we should update the nginx and other reverse proxy documentation to ask a header, otherwise some of them may not work.

I think it could be done later. The reasons are:

  1. The code is pretty safe, even if the reverse proxy configuration is wrong, there won't be real problem (for > 99.9% cases)
  2. The nginx document is already good enough
  3. I do not use other reverse proxies, so I don't want to mix the unclear parts in this PR

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 7, 2024 08:12
@wxiaoguang wxiaoguang merged commit 67c1a07 into go-gitea:main May 7, 2024
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 7, 2024
@wxiaoguang wxiaoguang deleted the fix-app-url branch May 7, 2024 08:40
@wxiaoguang wxiaoguang mentioned this pull request May 7, 2024
Merged
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

wxiaoguang commented May 7, 2024

To address the concern of "what about end users do not have their reverse proxy configured":

-> Check if reverse proxy is correctly configured #30890

wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request May 7, 2024
@wxiaoguang @KN4CK3R
Refactor AppURL usage (go-gitea#30885)
e9cd64b 
Fix go-gitea#30883
Fix go-gitea#29591

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@wxiaoguang wxiaoguang added type/bug backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels May 7, 2024
This was referenced May 7, 2024
Merged
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 8, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cc1ec32 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Apply to become a maintainer (go-gitea#30884)
  Refactor AppURL usage (go-gitea#30885)
  Move database operations of merging a pull request to post receive hook and add a transaction (go-gitea#30805)
  Fix missing migrate actions artifacts (go-gitea#30874)
wxiaoguang added a commit that referenced this pull request May 8, 2024
@wxiaoguang @KN4CK3R
Refactor AppURL usage (#30885) (#30891)
d4c2db3 
Backport #30885
Fix #30883
Fix #29591

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
wxiaoguang added a commit that referenced this pull request May 10, 2024
@wxiaoguang @silverwind @GiteaBot
Check if reverse proxy is correctly configured (#30890)
7424f27 
Follow #27011
Follow #30885

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request May 10, 2024
@wxiaoguang @silverwind @GiteaBot
Check if reverse proxy is correctly configured (go-gitea#30890)
376309c 
Follow go-gitea#27011
Follow go-gitea#30885

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this pull request May 10, 2024
Merged
wxiaoguang added a commit that referenced this pull request May 10, 2024
@GiteaBot @wxiaoguang @silverwind
Check if reverse proxy is correctly configured (#30890) (#30935)
b99473f 
Backport #30890 by wxiaoguang

Follow #27011
Follow #30885

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@wxiaoguang wxiaoguang mentioned this pull request May 17, 2024
Closed
@jpraet jpraet mentioned this pull request May 29, 2024
Closed
@kemzeb kemzeb mentioned this pull request May 30, 2024
Merged
lunny pushed a commit that referenced this pull request Jun 1, 2024
@kemzeb @wxiaoguang
Return an empty string when a repo has no avatar in the repo API (#31187
ab458ce 
)

Resolves #31167.

#30885 changed the behavior of
`repo.AvatarLink()` where it can now take the empty string and append it
to the app data URL. This does not point to a valid avatar image URL,
and, as the issue mentions, previous Gitea versions returned the empty
string.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@yp05327 yp05327 mentioned this pull request Jun 4, 2024
Closed
jpraet pushed a commit to jpraet/gitea that referenced this pull request Jul 5, 2024
@kemzeb @wxiaoguang @jpraet
Return an empty string when a repo has no avatar in the repo API (go-…
d27ddbf 
…gitea#31187)

Backport go-gitea#31187

Resolves go-gitea#31167.

go-gitea#30885 changed the behavior of
`repo.AvatarLink()` where it can now take the empty string and append it
to the app data URL. This does not point to a valid avatar image URL,
and, as the issue mentions, previous Gitea versions returned the empty
string.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@jpraet jpraet mentioned this pull request Jul 5, 2024
Merged
6543 pushed a commit that referenced this pull request Jul 5, 2024
@jpraet @kemzeb @wxiaoguang
Return an empty string when a repo has no avatar in the repo API (#31187
2dc6993 
) (#31567)

Backport #31187

Resolves #31167.

#30885 changed the behavior of
`repo.AvatarLink()` where it can now take the empty string and append it
to the app data URL. This does not point to a valid avatar image URL,
and, as the issue mentions, previous Gitea versions returned the empty
string.

Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

OCI Registry uses AppURL (ROOT_URL) no matter which address the client is connecting to (more Multi-Domain fallout)

4 participants

@wxiaoguang @lunny @KN4CK3R @GiteaBot