Return an empty string when a repo has no avatar in the repo API#31187
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
kemzeb
commented
May 30, 2024
wxiaoguang
reviewed
May 31, 2024
wxiaoguang
approved these changes
May 31, 2024
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
Oops, I forgot that the link could be empty
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
May 31, 2024
Member
|
Does |
delvh
approved these changes
May 31, 2024
GiteaBot
added
lgtm/done
delvh
changed the title
Member
Author
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 3, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix overflow in issue card (go-gitea#31203) Fix agit checkout command line hint & fix ShowMergeInstructions checking (go-gitea#31219) Fix the possible migration failure on 286 with postgres 16 (go-gitea#31209) Only update poster in issue/comment list if it has been loaded (go-gitea#31216) Return an empty string when a repo has no avatar in the repo API (go-gitea#31187) Split sanitizer functions and fine-tune some tests (go-gitea#31192) Performance improvements for pull request list API (go-gitea#30490) Fix URL In Gitea Actions Badge Docs (go-gitea#31191)
Member
|
@yardenshoham any idea what's missing to get the GiteaBot to backport this PR? Thanks |
Member
|
It creates backports whenever a new commit is pushed. There were no new commits since you added the label. |
jpraet
pushed a commit
to jpraet/gitea
that referenced
this pull request
Jul 5, 2024
…gitea#31187) Backport go-gitea#31187 Resolves go-gitea#31167. go-gitea#30885 changed the behavior of `repo.AvatarLink()` where it can now take the empty string and append it to the app data URL. This does not point to a valid avatar image URL, and, as the issue mentions, previous Gitea versions returned the empty string. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Member
I recall it had backported before even without any new commits, was that changed? |
Member
|
No. New commits were always the only trigger. |
Member
|
Imho, it should also watch when |
Member
|
It's a bit of a problem because we only have one filesystem so concurrent cherry-picks would happen. |
6543
pushed a commit
that referenced
this pull request
Jul 5, 2024
) (#31567) Backport #31187 Resolves #31167. #30885 changed the behavior of `repo.AvatarLink()` where it can now take the empty string and append it to the app data URL. This does not point to a valid avatar image URL, and, as the issue mentions, previous Gitea versions returned the empty string. Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Member
|
Hmm, sounds like you need some form of distributed locking. Redis could be used for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #31167.
#30885 changed the behavior of
repo.AvatarLink()where it can now take the empty string and append it to the app data URL. This does not point to a valid avatar image URL, and, as the issue mentions, previous Gitea versions returned the empty string.