Skip to content

Make test more robust #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2017
Merged

Make test more robust #3167

merged 2 commits into from
Dec 12, 2017

Conversation

ethantkoenig
Copy link
Member

The LFS API integration test has recently been flaky (e.g. https://drone.gitea.io/go-gitea/gitea/2559/10), so this PR increases the allow duration to reduce spurious failures.

@lafriks
Copy link
Member

lafriks commented Dec 12, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 12, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 12, 2017
@lunny
Copy link
Member

lunny commented Dec 12, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2017
@codecov-io
Copy link

codecov-io commented Dec 12, 2017 •
edited
Loading

Codecov Report

Merging #3167 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3167      +/-   ##
==========================================
- Coverage   34.74%   34.73%   -0.01%     
==========================================
  Files         276      276              
  Lines       39945    39945              
==========================================
- Hits        13878    13875       -3     
- Misses      24073    24074       +1     
- Partials     1994     1996       +2
Impacted Files Coverage Δ
models/repo_indexer.go 50.97% <0%> (-0.98%) ⬇️
models/repo.go 41.28% <0%> (-0.19%) ⬇️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad6333...fbd7647. Read the comment docs.

@appleboy appleboy merged commit 9f033bf into go-gitea:master Dec 12, 2017
@ethantkoenig ethantkoenig deleted the flaky_test branch December 13, 2017 04:24
@guillep2k guillep2k mentioned this pull request Oct 2, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ethantkoenig @lafriks @lunny @codecov-io @appleboy @tboerger