-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix lfs locks #8361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix lfs locks #8361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to github.com/lafriks/[email protected] (go-gitea#8317)
* [arc-green] white on hover for active menu items Actually, hovered active menu elements are in an unreadable black text colour. This should be changed to white. * [arc-green] white on hover for active menu items Actually, hovered active menu elements are in an unreadable black text colour. This should be changed to white. Now editing less files and commiting with `make css`.
…tc.) (go-gitea#7756) * Add API for Repo Advanced Settings of wiki and issue tracker Signed-off-by: David Svantesson <[email protected]> * Add some integration tests for tracker and wiki settings through API * Should return StatusUnprocessableEntity in case of invalid API values. * Add tests for invalid URLs for external tracker and wiki. * Do not set inital values if they are default of type * Make issue tracker and wiki units separate structures in Repository API structure. Signed-off-by: David Svantesson <[email protected]> * Fix comment of structures Signed-off-by: David Svantesson <[email protected]> * Rewrite API to use struct for setting tracker and wiki settings. * LetOnlyContributorsTrackTime -> AllowOnlyContributorsToTrackTime
Update master
sapk
approved these changes
Oct 2, 2019
I re-started the CI that failed on a unrelated test. |
Codecov Report
@@ Coverage Diff @@
## master #8361 +/- ##
==========================================
+ Coverage 41.76% 41.77% +<.01%
==========================================
Files 496 496
Lines 65610 65610
==========================================
+ Hits 27403 27407 +4
+ Misses 34691 34686 -5
- Partials 3516 3517 +1
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
TestAPILFSLocksLogged()
is recently failing due to a small time difference in the expected values.Some time ago (#3167) the allowed margin was extended from 1 to 3 seconds. With this PR I'm extending it to 10, as the servers seem to be somewhat slower lately.
EDIT: this is the error produced in the automated tests: