bump x/oauth2 & x/crypto (#33704)#33727
Merged
techknowlogick merged 8 commits intoFeb 28, 2025
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
techknowlogick
changed the title
techknowlogick
force-pushed
the
go-dep-bump-1.23
branch
from
830fcc2 to
0a0e378
Compare
delvh
approved these changes
Feb 26, 2025
GiteaBot
added
lgtm/need 1
techknowlogick
force-pushed
the
go-dep-bump-1.23
branch
from
c78497a to
a233ee1
Compare
silverwind
reviewed
Feb 26, 2025
| go 1.23 | ||
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.6 |
Member
There was a problem hiding this comment.
I don't know why go wants to introduce this toolchain directive and the .0 version here, but it seems like a go bug to me. See golang/go#65847 (comment) for my findings.
Member
There was a problem hiding this comment.
Likely the change itself is bening, toolchain is only a "suggestion" to the go compiler.
Member
|
The build failure seems persistent and odd. It looks as if |
Member
|
Pushed an attempt to fix license build with |
silverwind
reviewed
Feb 28, 2025
Member
|
#33747 will fix it, merge this after that one. |
silverwind
approved these changes
Feb 28, 2025
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport dep bump