Disable go license generation as part of make tidy
#33747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This was referenced Feb 28, 2025
silverwind
added
the
skip-changelog
lunny
approved these changes
Feb 28, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 28, 2025
delvh
approved these changes
Feb 28, 2025
GiteaBot
added
lgtm/done
|
Merging as this is blocking quite a few PRs now. |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Wait, why we merge it into main? I do not see any PR targeting "main" is blocked. Only these "1.23" PRs are blocked. Correct me if I was wrong. |
|
main had the problem with OS variance (#33745), so as a short-term measure I decided to have it on both branches. |
But that's a different problem, we shouldn't disable it on main branch. |
|
Feel free to re-enable, but personally I have enough of I think we will be better off replacing the licenses.txt with a SBOM file, could be generated with tools like https://github.com/aquasecurity/trivy. Or just remove it entirely. |
If you think the tool should be removed, then we should also remove the generated "go-license.json", because it will be out-of-sync soon. So either:
|
|
Let's discuss in #33749. |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 28, 2025
It seems something broken `google/go-licenses` (maybe related to go 1.24), and my findings are in google/go-licenses#128 (comment). I think it's best we disable this generation for now until a better solution is found. Also, enable showing stderr output so we can actually debug this thing. For reference, these are the errors that currently apparently break the tool: ``` E0228 05:15:27.005759 13158 library.go:117] Package text/tabwriter does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128. E0228 05:15:27.005776 13158 library.go:117] Package net/http/fcgi does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128. F0228 05:15:27.028122 13158 main.go:77] some errors occurred when loading direct and transitive dependency packages ```
lunny
pushed a commit
that referenced
this pull request
Mar 1, 2025
Backport #33747 by @silverwind It seems something broken `google/go-licenses` (maybe related to go 1.24), and my findings are in google/go-licenses#128 (comment). I think it's best we disable this generation for now until a better solution is found. Also, enable showing stderr output so we can actually debug this thing. For reference, these are the errors that currently apparently break the tool: ``` E0228 05:15:27.005759 13158 library.go:117] Package text/tabwriter does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128. E0228 05:15:27.005776 13158 library.go:117] Package net/http/fcgi does not have module info. Non go modules projects are no longer supported. For feedback, refer to google/go-licenses#128. F0228 05:15:27.028122 13158 main.go:77] some errors occurred when loading direct and transitive dependency packages ``` Co-authored-by: silverwind <[email protected]> Co-authored-by: techknowlogick <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 3, 2025
* giteaofficial/main: Use pullrequestlist instead of []*pullrequest (go-gitea#33765) Upgrade act to 0.261.4 and actions-proto-go to v0.4.1 (go-gitea#33760) Webhook add X-Gitea-Hook-Installation-Target-Type Header (go-gitea#33752) Fix dynamic content loading init problem (go-gitea#33748) [skip ci] Updated translations via Crowdin Add composor source field (go-gitea#33502) upgrade go-crypto from 1.1.5 to 1.1.6 (go-gitea#33745) Disable go license generation as part of `make tidy` (go-gitea#33747) Refactor repo-diff.ts (go-gitea#33746) Use `git diff-tree` for `DiffFileTree` on diff pages (go-gitea#33514) [skip ci] Updated translations via Crowdin Improve "generate new access token" form (go-gitea#33730) Remove superflous tw-content-center (go-gitea#33741) Clone repository with Tea CLI (go-gitea#33725) allow filtering /repos/{owner}/{repo}/pulls by target base branch queryparam (go-gitea#33684) Show info about maintainers are allowed to edit a PR (go-gitea#33738) Improve admin user view page (go-gitea#33735) [skip ci] Updated translations via Crowdin Align sidebar gears to the right (go-gitea#33721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems something broken
google/go-licenses(maybe related to go 1.24), and my findings are in google/go-licenses#128 (comment). I think it's best we disable this generation for now until a better solution is found.Also, enable showing stderr output so we can actually debug this thing. For reference, these are the errors that currently apparently break the tool: