Fix RPM Registry 404 when package name contains 'package'#37087
Merged
Conversation
Swap the order of overlapping routes in api.go to prevent the short route from intercepting long paths when the name contains 'package'. Fixes go-gitea#37086 Signed-off-by: Rohan Guliani <rohansguliani@google.com>
GiteaBot
added
the
lgtm/need 2
bircni
reviewed
Apr 2, 2026
Member
bircni
left a comment
bircni
left a comment
There was a problem hiding this comment.
Fix is correct.
I would really like to see a Comment here to explain why we do this.
The root cause is still unfixed though.
The real issue is that <group:*> using (.*?) across / boundaries creates ambiguity with the literal package/ segment.
Also I think a test would be great for this to cover...
Signed-off-by: Rohan Guliani <rohansguliani@google.com>
Contributor
|
Good catch! Thank you very much. btw: I think we can do more "fixes", I will do it, just a moment. |
Contributor
|
It is a bug in "MatchPath", the generated regexp is |
Contributor
|
Completely fixed in the framework. |
Contributor
|
Now, even if you swap the two MatchPath routes to old order, the test still passes. Everything should be right now. Will do final clean up and mark it ready for review. |
wxiaoguang
approved these changes
Apr 3, 2026
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 3, 2026
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 3, 2026
* main: Fix RPM Registry 404 when package name contains 'package' (go-gitea#37087) Improve actions notifier for `workflow_run` (go-gitea#37088) Refactor code render and render control chars (go-gitea#37078) Fix various problems (go-gitea#37077) [skip ci] Updated translations via Crowdin Support legacy run/job index-based URLs and refactor migration 326 (go-gitea#37008) Fix a bug when forking a repository in an organization (go-gitea#36950)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37086, fix the bug in MatchPath, and swap the order of overlapping routes in api.go to make it look better.