Skip to content

Fix RPM Registry 404 when package name contains 'package' #37087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 8 commits into from
Apr 3, 2026
+27 −5
Merged

Fix RPM Registry 404 when package name contains 'package' #37087

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
86215d5
Fix RPM Registry 404 when package name contains 'package'
Rohansguliani Apr 2, 2026
7d9a132
Add comment and integration test for RPM routing collision
Rohansguliani Apr 2, 2026
94af7e2
fix comment
wxiaoguang Apr 3, 2026
54bace1
fix framework
wxiaoguang Apr 3, 2026
35873d4
fix comment
wxiaoguang Apr 3, 2026
6b5ffb7
add comments, remove package-specific test (framework already gets co…
wxiaoguang Apr 3, 2026
2e95e8f
Merge branch 'main' into fix-rpm-routing-main-37086
GiteaBot Apr 3, 2026
132e924
Merge branch 'main' into fix-rpm-routing-main-37086
GiteaBot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routers/api/packages/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,8 @@ func CommonRoutes() *web.Router {
g.MatchPath("GET", "/<group:*>/repodata/<filename>", rpm.GetRepositoryFile)
g.MatchPath("PUT", "/<group:*>/upload", reqPackageAccess(perm.AccessModeWrite), rpm.UploadPackageFile)
// this URL pattern is only used internally in the RPM index, it is generated by us, the filename part is not really used (can be anything)
g.MatchPath("HEAD,GET", "/<group:*>/package/<name>/<version>/<architecture>", rpm.DownloadPackageFile)
g.MatchPath("HEAD,GET", "/<group:*>/package/<name>/<version>/<architecture>/<filename>", rpm.DownloadPackageFile)
g.MatchPath("HEAD,GET", "/<group:*>/package/<name>/<version>/<architecture>", rpm.DownloadPackageFile)
g.MatchPath("DELETE", "/<group:*>/package/<name>/<version>/<architecture>", reqPackageAccess(perm.AccessModeWrite), rpm.DeletePackageFile)
}, reqPackageAccess(perm.AccessModeRead))

Expand Down