fix: use TriggerEvent instead of Event in workflow runs API response for scheduled runs

[KalashThakare]

Summary

Fixes #37252

The /api/v1/repos/{owner}/{repo}/actions/runs endpoint was returning
event: "push" for workflow runs triggered by schedule: (cron), instead
of event: "schedule".

Root Cause

ActionRun has two separate fields:

• Event — the workflow registration event (e.g. push, set when the workflow file was first pushed)
• TriggerEvent — the actual event that triggered the run (e.g. schedule)

ToActionWorkflowRun in services/convert/action.go was serializing
run.Event into the API response instead of run.TriggerEvent, causing
scheduled runs to be indistinguishable from push events via the API.

This was already asymmetric — the tasks/jobs API correctly used TriggerEvent.

Fix

Changed ToActionWorkflowRun to use run.TriggerEvent for the event
field in the API response, consistent with how the jobs API works.

Before

event: "push" returned for all scheduled runs:

After

event: "schedule" correctly returned for scheduled runs:

Testing

• Added unit test TestToActionWorkflowRun_UsesTriggerEvent in
  services/convert/action_test.go that explicitly verifies the API
  returns TriggerEvent and not Event for a scheduled run.
• Manually verified via the API against a live Gitea instance with a
  cron: "* * * * *" workflow.

[bircni]

To make it more clear should we publish both via api?

[KalashThakare]

To make it more clear should we publish both via api?

yes i think we should as it will eventually help consumers get more context.

[bircni]

and maybe also have a look how github behaves here - especially for api its good to have nearly the same

[KalashThakare]

and maybe also have a look how github behaves here - especially for api its good to have nearly the same

ok i will look into it.

[silverwind]

Two minor items worth addressing:

1. Redundant assertion in services/convert/action_test.go — assert.NotEqual(t, string(run.Event), apiRun.Event) adds nothing once the preceding assert.Equal(t, "schedule", apiRun.Event) holds with run.Event = "push". Safe to drop.

2. Integration coverage gap — this bug slipped past tests/integration/workflow_run_api_check_test.go because every existing action_run fixture has event == trigger_event. Adding a scheduled-run fixture where the two differ would guard against regression at the API layer, not just the converter.

---

This comment was written by Claude Opus 4.7.

[KalashThakare]

and maybe also have a look how github behaves here - especially for api its good to have nearly the same

Github only exposes event field( actual event that triggered the run )

[bircni]

Two minor items worth addressing:

1. Redundant assertion in services/convert/action_test.go — assert.NotEqual(t, string(run.Event), apiRun.Event) adds nothing once the preceding assert.Equal(t, "schedule", apiRun.Event) holds with run.Event = "push". Safe to drop.

2. Integration coverage gap — this bug slipped past tests/integration/workflow_run_api_check_test.go because every existing action_run fixture has event == trigger_event. Adding a scheduled-run fixture where the two differ would guard against regression at the API layer, not just the converter.

---

This comment was written by Claude Opus 4.7.

Did you address them?

[bircni]

@silverwind addressed your requests