Fix URL related escaping for oauth2 (#37334)#37340
Merged
Merged
Conversation
Follow up go-gitea#37327. See the comments. * Root problem: the design of OAuth2 providers is a mess, the display name is used as provider's name and used in the URL directly * The regressions: * When trying to fix go-gitea#36409 , it introduced inconsistent URL escaping for the "path" part. * This fix: always use "path escaping" for the path part, add more tests to cover all escaping cases. Now, frontend "pathEscape" and "pathEscapeSegments" generate exactly the same result as backend.
GiteaBot
added
the
lgtm/need 2
bircni
approved these changes
Apr 21, 2026
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Apr 21, 2026
GiteaBot
added
lgtm/done
lunny
approved these changes
Apr 21, 2026
yamz8
pushed a commit
to kerneliushq/kernelius-forge-cli
that referenced
this pull request
May 11, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker.gitea.com/gitea](https://github.com/go-gitea/gitea) | service | patch | `1.26.0` → `1.26.1` | --- ### Release Notes <details> <summary>go-gitea/gitea (docker.gitea.com/gitea)</summary> ### [`v1.26.1`](https://github.com/go-gitea/gitea/releases/tag/v1.26.1) [Compare Source](go-gitea/gitea@v1.26.0...v1.26.1) - BUGFIXES \* Add event.schedule context for schedule actions task ([#​37320](go-gitea/gitea#37320)) ([#​37348](go-gitea/gitea#37348)) \* Fix an issue where changing an organization's visibility caused problems when users had forked its repositories. ([#​37324](go-gitea/gitea#37324)) ([#​37344](go-gitea/gitea#37344)) \* Use modern "git update-index --cacheinfo" syntax to support more file names ([#​37338](go-gitea/gitea#37338)) ([#​37343](go-gitea/gitea#37343)) \* Fix URL related escaping for oauth2 ([#​37334](go-gitea/gitea#37334)) ([#​37340](go-gitea/gitea#37340)) \* When the requested arch rpm is missing fall back to noarch ([#​37236](go-gitea/gitea#37236)) ([#​37339](go-gitea/gitea#37339)) \* Fix actions concurrency groups cross-branch leak ([#​37311](go-gitea/gitea#37311)) ([#​37331](go-gitea/gitea#37331)) \* Fix bug when accessing user badges ([#​37321](go-gitea/gitea#37321)) ([#​37329](go-gitea/gitea#37329)) \* Fix AppFullLink ([#​37325](go-gitea/gitea#37325)) ([#​37328](go-gitea/gitea#37328)) \* Fix container auth for public instance ([#​37290](go-gitea/gitea#37290)) ([#​37294](go-gitea/gitea#37294)) \* Enhance GetActionWorkflow to support fallback references ([#​37189](go-gitea/gitea#37189)) ([#​37283](go-gitea/gitea#37283)) \* Fix vite manifest update masking build errors ([#​37279](go-gitea/gitea#37279)) ([#​37310](go-gitea/gitea#37310)) \* Fix Mermaid diagrams failing when node labels contain line breaks ([#​37296](go-gitea/gitea#37296)) ([#​37299](go-gitea/gitea#37299)) \* Use TriggerEvent instead of Event in workflow runs API response for scheduled runs ([#​37288](go-gitea/gitea#37288)) [#​37360](go-gitea/gitea#37360) \* Add URL to Learn more about blocking a user. ([#​37355](go-gitea/gitea#37355)) [#​37367](go-gitea/gitea#37367) \* Fix button layout shift when collapsing file tree in editor ([#​37363](go-gitea/gitea#37363)) [#​37375](go-gitea/gitea#37375) \* Fix org team assignee/reviewer lookups for team member permissions ([#​37365](go-gitea/gitea#37365)) [#​37391](go-gitea/gitea#37391) \* Fix repo init README EOL ([#​37388](go-gitea/gitea#37388)) [#​37399](go-gitea/gitea#37399) \* Fix: dump with default zip type produces uncompressed zip ([#​37401](https://github.com/go-gitea/gitea/issues/37401))[#​37402](https://github.com/go-gitea/gitea/issues/37402) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://gitea.com/gitea/tea/pulls/968 Co-authored-by: Renovate Bot <renovate-bot@gitea.com> Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37334 by @wxiaoguang
Follow up #37327. See the comments.
Now, frontend "pathEscape" and "pathEscapeSegments" generate exactly the same result as backend.