Add security advice to contrib guide #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember… on GitHub you could actually enforce 2FA for the organization. |
bkcsoft
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #4187 +/- ##
=======================================
Coverage 19.97% 19.97%
=======================================
Files 153 153
Lines 30494 30494
=======================================
Hits 6091 6091
Misses 23489 23489
Partials 914 914Continue to review full report at Codecov.
|
rugk
approved these changes
Jun 8, 2018
techknowlogick
approved these changes
Jun 8, 2018
bkcsoft
added
lgtm/need 1
axifive
approved these changes
Jun 8, 2018
|
LGTM |
bkcsoft
added
lgtm/done
daviian
suggested changes
Jun 9, 2018
CONTRIBUTING.md
Outdated
| @@ -201,6 +201,10 @@ an advisor has time to code review, we will gladly welcome them back | |||
| to the maintainers team. If a maintainer is inactive for more than 3 | |||
| months and forgets to leave the maintainers team, the owners may move | |||
| him or her from the maintainers team to the advisors team. | |||
| For security reasons, Maintainers should use 2FA for theirs accounts and | |||
daviian
approved these changes
Jun 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little reminder.
Related to #4167