Skip to content

Add security advice to contrib guide #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 9, 2018
Merged

Add security advice to contrib guide #4187

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7406443
Improve contributing guidelines for security
sapk Jun 8, 2018
618d580
Update CONTRIBUTING.md
sapk Jun 8, 2018
c5340c3
Update CONTRIBUTING.md
sapk Jun 8, 2018
b2f12a0
Update CONTRIBUTING.md
sapk Jun 8, 2018
7ec5da4
Update CONTRIBUTING.md
sapk Jun 8, 2018
b30cc8c
Merge branch 'master' into improve-contrib-guide
techknowlogick Jun 9, 2018
097b652
remove extra 's'
sapk Jun 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,10 @@ an advisor has time to code review, we will gladly welcome them back
to the maintainers team. If a maintainer is inactive for more than 3
months and forgets to leave the maintainers team, the owners may move
him or her from the maintainers team to the advisors team.
For security reasons, Maintainers should use 2FA for their accounts and
if possible provide gpg signed commits.
https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/
https://help.github.com/articles/signing-commits-with-gpg/

## Owners

Expand All @@ -211,6 +215,9 @@ be the main owner, and the other two the assistant owners. When the new
owners have been elected, the old owners will give up ownership to the
newly elected owners. If an owner is unable to do so, the other owners
will assist in ceding ownership to the newly elected owners.
For security reasons, Owners or any account with write access (like a bot)
must use 2FA.
https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/

After the election, the new owners should proactively agree
with our [CONTRIBUTING](CONTRIBUTING.md) requirements in the
Expand Down