Update vendor/go-sqlite3#5133
Merged
Merged
Conversation
Contributor
Author
|
@lunny Should I skip the changes of build tags for now? |
bkcsoft
added
the
lgtm/need 2
typeless
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5133 +/- ##
=======================================
Coverage 37.48% 37.48%
=======================================
Files 309 309
Lines 45782 45782
=======================================
Hits 17161 17161
- Misses 26158 26159 +1
+ Partials 2463 2462 -1
Continue to review full report at Codecov.
|
typeless
force-pushed
the
update-vendor-go-sqlite3
branch
from
c01bd5f to
b5ad496
Compare
techknowlogick
added
the
type/refactoring
typeless
force-pushed
the
update-vendor-go-sqlite3
branch
3 times, most recently
from
bb2ca0a to
fe23f1d
Compare
Contributor
Author
|
Will update this PR when #5134 is merged. |
typeless
force-pushed
the
update-vendor-go-sqlite3
branch
from
fe23f1d to
5987e28
Compare
Contributor
Author
Done. |
Member
Contributor
Author
|
@lunny Yes |
sapk
approved these changes
Oct 22, 2018
bkcsoft
added
lgtm/need 1
typeless
force-pushed
the
update-vendor-go-sqlite3
branch
from
5987e28 to
266512d
Compare
typeless
changed the title
Contributor
Author
|
I split the PR into two. Now, this one is only for updating vendor/go-sqlite3. A later PR will update the build tags. |
lunny
approved these changes
Oct 23, 2018
bkcsoft
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update vendor/github/mattn/go-sqlite3.