Skip to content

Remove x/net/context vendor by using std package #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2018

Conversation

sapk
Copy link
Member

@sapk sapk commented Oct 27, 2018

This PR update

  • github.com/markbates/goth
  • github.com/blevesearch/bleve
  • golang.org/x/oauth2

To remove the unneeded vendor x/net/context since Go1.7.

This PR is still in WIP since it wait for an other PR on golang.org/x/oauth2. golang/oauth2#339

@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@b3000ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5202   +/-   ##
=========================================
  Coverage          ?   37.35%           
=========================================
  Files             ?      312           
  Lines             ?    46379           
  Branches          ?        0           
=========================================
  Hits              ?    17323           
  Misses            ?    26573           
  Partials          ?     2483

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3000ae...49e4717. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2018
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 27, 2018
@techknowlogick techknowlogick added the pr/wip This PR is not ready for review label Oct 27, 2018
@techknowlogick
Copy link
Member

@sapk can you link to PR that is blocking this in golang.org/x/oauth2?

@sapk
Copy link
Member Author

sapk commented Oct 27, 2018

@techknowlogick techknowlogick added status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR and removed pr/wip This PR is not ready for review labels Oct 28, 2018
@techknowlogick techknowlogick changed the title [WIP] Remove x/net/context vendor by using std package Remove x/net/context vendor by using std package Oct 28, 2018
@techknowlogick
Copy link
Member

Thanks @sapk

@techknowlogick techknowlogick removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Nov 1, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2018
@sapk
Copy link
Member Author

sapk commented Nov 2, 2018

There is still x/net/context in vendor since I found that x/net/context/ctxhttp is use at one (and only) point in x/oauth2. I will try to push the fix to oauth2 as it not really needed to use ctxhttp for it.
Still this PR could be merge as it still update deps that were using x/net/context and will ease the process for the next.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2018
@lunny
Copy link
Member

lunny commented Nov 9, 2018

conflicted

@sapk sapk force-pushed the remove-net-vendor branch from 688a23b to 7a8a07a Compare November 10, 2018 19:05
@sapk
Copy link
Member Author

sapk commented Nov 10, 2018

@lunny I rebased on master. It should be good.

@techknowlogick techknowlogick merged commit 4c1f1f9 into go-gitea:master Nov 10, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants