-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Remove x/net/context vendor by using std package #5202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5202 +/- ##
=========================================
Coverage ? 37.35%
=========================================
Files ? 312
Lines ? 46379
Branches ? 0
=========================================
Hits ? 17323
Misses ? 26573
Partials ? 2483 Continue to review full report at Codecov.
|
@sapk can you link to PR that is blocking this in golang.org/x/oauth2? |
Thanks @sapk |
There is still x/net/context in vendor since I found that x/net/context/ctxhttp is use at one (and only) point in x/oauth2. I will try to push the fix to oauth2 as it not really needed to use ctxhttp for it. |
conflicted |
688a23b
to
7a8a07a
Compare
@lunny I rebased on master. It should be good. |
This PR update
To remove the unneeded vendor x/net/context since Go1.7.
This PR is still in WIP since it wait for an other PR on golang.org/x/oauth2. golang/oauth2#339