Skip to content

all: use stdlib context instead of x/net/context #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

all: use stdlib context instead of x/net/context #339

wants to merge 1 commit into from

Conversation

sapk
Copy link
Contributor

@sapk sapk commented Oct 27, 2018 •
edited by bradfitz
Loading

This PR replaces use of x/net/context with the standard context
It has been nearly 6 months since #246 (comment) so I made this PR so it will be ready to merge when needed (and if possible).

Fixes #246

@gopherbot
Copy link
Contributor

This PR (HEAD: 5b36321) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/145202 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/145202.
After addressing review feedback, remember to publish your drafts!

@sapk sapk mentioned this pull request Oct 27, 2018
Merged
@bradfitz bradfitz changed the title Replace x/net/context by standard package all: use stdlib context instead of x/net/context Nov 1, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/145202.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/145202.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 1, 2018
@sapk @bradfitz
all: use stdlib context instead of x/net/context
c453e0c 
This PR replaces use of `x/net/context` with the standard `context`

It has been nearly 6 months since
#246 (comment) so
I made this PR so it will be ready to merge when needed (and if
possible).

Fixes #246

Change-Id: Id2c316fcb27de0fb9163ceb4e8669b04cb39a987
GitHub-Last-Rev: 5b36321
GitHub-Pull-Request: #339
Reviewed-on: https://go-review.googlesource.com/c/145202
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/145202 has been merged.

@gopherbot gopherbot closed this Nov 1, 2018
@sapk sapk deleted the fix-246 branch November 1, 2018 17:21
@sapk sapk mentioned this pull request Nov 1, 2018
Closed
gopherbot pushed a commit that referenced this pull request Nov 2, 2018
@sapk @bradfitz
appengine: use stdlib context instead of x/net/context
e0f2c55 
PR #341 introduce some new import `x/net/context` in parallel of PR #339 replacing them with the standard context.
This quick PR rename those imports.

Change-Id: I94f7edbee851a733b8a307c2ea60923dd990bdb4
GitHub-Last-Rev: fbe7944
GitHub-Pull-Request: #342
Reviewed-on: https://go-review.googlesource.com/c/146837
Reviewed-by: Brad Fitzpatrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapk @gopherbot @googlebot