Don't close issues via commits on non-default branch.#5622
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5622 +/- ##
==========================================
+ Coverage 37.81% 37.82% +<.01%
==========================================
Files 322 322
Lines 47474 47471 -3
==========================================
+ Hits 17954 17957 +3
+ Misses 26933 26926 -7
- Partials 2587 2588 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
zeripath
suggested changes
Jan 3, 2019
HarshitOnGitHub
force-pushed
the
Issue_2314
branch
from
6cd614c to
82be19a
Compare
Adds a small check to close the issues only if the referencing commits are on the default branch. Fixes: go-gitea#2314.
HarshitOnGitHub
force-pushed
the
Issue_2314
branch
from
82be19a to
8660b18
Compare
zeripath
approved these changes
Jan 3, 2019
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Jan 4, 2019
bkcsoft
added
lgtm/done
lafriks
changed the title
Member
|
please send commit 9f476b8 backport to release/v1.7 branch |
HarshitOnGitHub
added a commit
to HarshitOnGitHub/gitea
that referenced
this pull request
Jan 5, 2019
Adds a small check to close the issues only if the referencing commits are on the default branch. Fixes: go-gitea#2314.
lafriks
pushed a commit
that referenced
this pull request
Jan 5, 2019
techknowlogick
added
the
backport/done
lunny
added
the
pr/breaking
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a bug fix as well as a small refactor.
Fixes: #2314.