Skip to content

Add option to close issues via commit on a non master branch#5992

Merged
lafriks merged 11 commits into
go-gitea:masterfrom
adelowo:add_option_to_close_issues_via_commit_on_a_non_master_branch
Feb 10, 2019
Merged

Add option to close issues via commit on a non master branch#5992
lafriks merged 11 commits into
go-gitea:masterfrom
adelowo:add_option_to_close_issues_via_commit_on_a_non_master_branch

Conversation

@adelowo
Copy link
Copy Markdown
Member

@adelowo adelowo commented Feb 7, 2019

.. #5622 introduced a breaking change. This adds an option to configure the behavior
of that PR.

Fixes #5957

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2019

Codecov Report

Merging #5992 into master will increase coverage by <.01%.
The diff coverage is 29.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5992      +/-   ##
==========================================
+ Coverage   38.72%   38.72%   +<.01%     
==========================================
  Files         338      339       +1     
  Lines       48994    49013      +19     
==========================================
+ Hits        18971    18980       +9     
- Misses      27276    27286      +10     
  Partials     2747     2747
Impacted Files Coverage Δ
models/migrations/migrations.go 1.52% <ø> (ø) ⬆️
modules/setting/setting.go 47.68% <ø> (ø) ⬆️
modules/auth/repo_form.go 39% <ø> (ø) ⬆️
routers/repo/setting.go 10.25% <0%> (-0.11%) ⬇️
models/migrations/v79.go 0% <0%> (ø)
models/repo.go 47.27% <100%> (+0.03%) ⬆️
models/action.go 60.98% <100%> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0adb5e...acad54e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 7, 2019
@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 7, 2019
Comment thread custom/conf/app.ini.sample Outdated
…nstance

Also note that the config value can still be set so as to be able to control the value for new repositories that are to be created

- fix copy/paste error in copyright header year and rearrange import

- use repo config instead of server config value to determine if a commit should close an issue

- update testsuite
@adelowo adelowo force-pushed the add_option_to_close_issues_via_commit_on_a_non_master_branch branch from 6b6df75 to 98b92a1 Compare February 9, 2019 11:45
Comment thread custom/conf/app.ini.sample Outdated
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2019
@adelowo
Copy link
Copy Markdown
Member Author

adelowo commented Feb 10, 2019

Oops .. will fix CI as soon as I jump back on my machine

CI passes now :)

@lafriks lafriks merged commit 9d8178b into go-gitea:master Feb 10, 2019
@adelowo adelowo deleted the add_option_to_close_issues_via_commit_on_a_non_master_branch branch February 10, 2019 20:18
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing issues via commit on non-default branch

6 participants