build: remove unused REGISTRYURL and GCS download path for registry build by SoumyaRaikwar · Pull Request #22372 · goharbor/harbor

SoumyaRaikwar · 2025-09-21T21:34:59Z

This PR addresses issue #22333.

Changes:

Drop REGISTRYURL variable and stop propagating it to sub-make.
Simplify make/photon/Makefile to always build the registry from source via the existing builder script.
Remove the Google Storage URL that was previously used to download a prebuilt registry binary.

Rationale:

The REGISTRYURL parameter and the related GCS download path are no longer used in the build pipeline.
Building the registry from source is the supported path and avoids relying on external binary artifacts.

Notes:

No Go code changes. CI should verify Makefile behavior remains intact.

MinerYang · 2025-09-22T07:15:22Z

Hi @SoumyaRaikwar ,

Thanks for contributing to harbor community.
However this Param is not unused. It will be consumed on demand.

Best,
Miner

reasonerjt · 2025-09-22T08:51:19Z

@SoumyaRaikwar
Thank you for the PR. However, when checking the PR we find there's a misunderstanding in #22333, that this parm may still be needed in some custom cases when some downstream tries to download binaries from a 3rd server in the build process.

@wy65701436 please follow up and clarify.

…binary (address review) - Keep REGISTRYURL variable (empty by default) and pass-through to sub-make - Restore conditional registry download path and _get_binary helper in photon Makefile - Aligns with reviewer guidance on goharbor#22372 Signed-off-by: Your Name <your.email@example.com>

SoumyaRaikwar · 2025-09-22T09:13:23Z

Thanks for the review. I’ve addressed the feedback:

Restored REGISTRYURL in the top-level Makefile (left empty by default).
Passed REGISTRYURL through to the photon sub-make build.
Restored the conditional download path in make/photon/Makefile for non-BUILDREG builds.
Restored _get_binary helper.
Kept removal of the hardcoded GCS URL.

@stonezdj Please take another look. Thanks!"

codecov · 2025-09-22T09:34:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.92%. Comparing base (c8c11b4) to head (898e674).
⚠️ Report is 655 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #22372       +/-   ##
===========================================
+ Coverage   45.36%   65.92%   +20.55%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116413   +103080     
  Branches     2719     2937      +218     
===========================================
+ Hits         6049    76746    +70697     
- Misses       6983    35419    +28436     
- Partials      301     4248     +3947

Flag	Coverage Δ
unittests	`65.92% <ø> (+20.55%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 989 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wy65701436

thanks for your contribution. LGTM

SoumyaRaikwar · 2025-09-22T11:55:37Z

Hi! @stonezdj , could you please review my pr.

bupd

lgtm

SoumyaRaikwar · 2025-09-23T17:42:37Z

Hi! @stonezdj @Vad1mo ,could you please review my pr ?

wy65701436

lgtm

SoumyaRaikwar · 2025-09-26T00:16:03Z

@stonezdj could you please review my pr

…uild Closes goharbor#22333 - Drop REGISTRYURL variable and its propagation - Simplify make/photon/Makefile to always build registry from source via builder - Remove Google Storage URL reference used for downloading prebuilt registry binary Signed-off-by: Your Name <your.email@example.com>

…binary (address review) - Keep REGISTRYURL variable (empty by default) and pass-through to sub-make - Restore conditional registry download path and _get_binary helper in photon Makefile - Aligns with reviewer guidance on goharbor#22372 Signed-off-by: Your Name <your.email@example.com>

Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com>

SoumyaRaikwar · 2025-09-29T18:58:30Z

Hi @stonezdj @MinerYang @Vad1mo,

Could you please approve the workflow runs for this PR?

SoumyaRaikwar · 2025-10-03T12:40:18Z

@bupd could you please approve the workflows run on my pr ?

SoumyaRaikwar · 2025-10-17T12:48:13Z

@wy65701436 @stonezdj The PR has been approved and auto-merge is enabled, but it seems to be waiting on workflow approval. Could you please approve the CI runs when you get a chance? Thank you!

bupd

its about time. We should merge this.

github-actions · 2026-01-23T09:08:42Z

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

bupd · 2026-01-23T13:10:06Z

/label never-stale

bupd · 2026-01-23T13:10:49Z

@SoumyaRaikwar can you rebase your pr to main branch.

Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>

…uild (goharbor#22372) * build: remove unused REGISTRYURL and GCS download path for registry build Closes goharbor#22333 - Drop REGISTRYURL variable and its propagation - Simplify make/photon/Makefile to always build registry from source via builder - Remove Google Storage URL reference used for downloading prebuilt registry binary Signed-off-by: Your Name <your.email@example.com> * build: keep REGISTRYURL var and fallback download path; restore _get_binary (address review) - Keep REGISTRYURL variable (empty by default) and pass-through to sub-make - Restore conditional registry download path and _get_binary helper in photon Makefile - Aligns with reviewer guidance on goharbor#22372 Signed-off-by: Your Name <your.email@example.com> * Update Makefile Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> * Update Makefile Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> * Update Makefile Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> --------- Signed-off-by: Your Name <your.email@example.com> Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com> Co-authored-by: Your Name <your.email@example.com> Co-authored-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com> Signed-off-by: sias32 <sias.32@yandex.ru>

…uild (goharbor#22372) * build: remove unused REGISTRYURL and GCS download path for registry build Closes goharbor#22333 - Drop REGISTRYURL variable and its propagation - Simplify make/photon/Makefile to always build registry from source via builder - Remove Google Storage URL reference used for downloading prebuilt registry binary Signed-off-by: Your Name <your.email@example.com> * build: keep REGISTRYURL var and fallback download path; restore _get_binary (address review) - Keep REGISTRYURL variable (empty by default) and pass-through to sub-make - Restore conditional registry download path and _get_binary helper in photon Makefile - Aligns with reviewer guidance on goharbor#22372 Signed-off-by: Your Name <your.email@example.com> * Update Makefile Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> * Update Makefile Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> * Update Makefile Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> --------- Signed-off-by: Your Name <your.email@example.com> Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com> Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com> Co-authored-by: Your Name <your.email@example.com> Co-authored-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com> Signed-off-by: sias32 <sias320@gmail.com>

SoumyaRaikwar requested a review from a team as a code owner September 21, 2025 21:35

github-actions Bot assigned stonezdj, Vad1mo and wy65701436 Sep 21, 2025

SoumyaRaikwar mentioned this pull request Sep 21, 2025

Remove unused parameter REGISTRYURL in build #22333

Closed

reasonerjt added the needs/follow-up label Sep 22, 2025

stonezdj reviewed Sep 22, 2025

View reviewed changes

Comment thread Makefile

stonezdj reviewed Sep 22, 2025

View reviewed changes

Comment thread Makefile

stonezdj reviewed Sep 22, 2025

View reviewed changes

Comment thread make/photon/Makefile

stonezdj reviewed Sep 22, 2025

View reviewed changes

Comment thread make/photon/Makefile

wy65701436 reviewed Sep 22, 2025

View reviewed changes

Comment thread Makefile Outdated

SoumyaRaikwar requested review from stonezdj and wy65701436 September 22, 2025 09:23

wy65701436 approved these changes Sep 22, 2025

View reviewed changes

wy65701436 added the release-note/update Update or Fix label Sep 22, 2025

SoumyaRaikwar requested a review from wy65701436 September 23, 2025 03:49

bupd approved these changes Sep 23, 2025

View reviewed changes

wy65701436 enabled auto-merge (squash) September 25, 2025 07:43

wy65701436 approved these changes Sep 25, 2025

View reviewed changes

stonezdj approved these changes Sep 29, 2025

View reviewed changes

Your Name added 2 commits September 29, 2025 16:20

SoumyaRaikwar added 2 commits September 29, 2025 16:20

Update Makefile

1b813fe

Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com>

Update Makefile

0952395

Signed-off-by: Soumya Raikwar <164396577+SoumyaRaikwar@users.noreply.github.com>

stonezdj force-pushed the 22333-remove-unused-registryurl branch from 76de3b0 to 0952395 Compare September 29, 2025 08:20

Merge branch 'main' into 22333-remove-unused-registryurl

83b957f

SoumyaRaikwar requested review from bupd, stonezdj and wy65701436 October 3, 2025 16:52

Merge branch 'main' into 22333-remove-unused-registryurl

f7a4c8d

Merge branch 'main' into 22333-remove-unused-registryurl

1eb26e2

SoumyaRaikwar marked this pull request as draft November 13, 2025 20:58

auto-merge was automatically disabled November 13, 2025 20:58
Pull request was converted to draft

SoumyaRaikwar marked this pull request as ready for review November 13, 2025 20:58

github-actions Bot assigned chlins and MinerYang Nov 13, 2025

bupd approved these changes Nov 23, 2025

View reviewed changes

github-actions Bot added the Stale label Jan 23, 2026

github-actions Bot removed the Stale label Jan 24, 2026

stonezdj approved these changes Jan 29, 2026

View reviewed changes

Merge branch 'main' into 22333-remove-unused-registryurl

898e674

Signed-off-by: stonezdj(Daojun Zhang) <stonezdj@gmail.com>

stonezdj enabled auto-merge (squash) January 29, 2026 09:41

stonezdj merged commit fe7f2c3 into goharbor:main Jan 29, 2026
12 checks passed

Conversation

SoumyaRaikwar commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MinerYang commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reasonerjt commented Sep 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SoumyaRaikwar commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wy65701436 left a comment

Choose a reason for hiding this comment

Uh oh!

SoumyaRaikwar commented Sep 22, 2025

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

SoumyaRaikwar commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wy65701436 left a comment

Choose a reason for hiding this comment

Uh oh!

SoumyaRaikwar commented Sep 26, 2025

Uh oh!

SoumyaRaikwar commented Sep 29, 2025

Uh oh!

SoumyaRaikwar commented Oct 3, 2025

Uh oh!

SoumyaRaikwar commented Oct 17, 2025

Uh oh!

bupd left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

bupd commented Jan 23, 2026

Uh oh!

bupd commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

SoumyaRaikwar commented Sep 21, 2025 •

edited

Loading

MinerYang commented Sep 22, 2025 •

edited

Loading

SoumyaRaikwar commented Sep 22, 2025 •

edited

Loading

codecov Bot commented Sep 22, 2025 •

edited

Loading

SoumyaRaikwar commented Sep 23, 2025 •

edited

Loading