Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Adjust appveyor build script to automatically exclude vendor/ #542

Merged
merged 4 commits into from
May 10, 2017
Merged

Adjust appveyor build script to automatically exclude vendor/ #542

merged 4 commits into from
May 10, 2017

Conversation

davecheney
Copy link
Contributor

Itemising packages to test on windows is fiddly and can lead to packages being untested on windows by accident.

Adjust the appveyor script to determine the list of packages to test (aka, exclude vendor/) automatically.

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@sdboyer
Copy link
Member

sdboyer commented May 10, 2017

(silly googlebot)

thanks, this is definitely much better!

@sdboyer sdboyer merged commit 1ecd916 into golang:master May 10, 2017
@sdboyer
Copy link
Member

sdboyer commented May 18, 2017

err...well, it was hopefully much better. but it seems that test failures don't cause build failures 😢 https://ci.appveyor.com/project/golang/dep/build/824/job/3hut17cgpyiepjae

@dcheney-atlassian
Copy link

This is why we cannot have nice things.

@sdboyer
Copy link
Member

sdboyer commented May 18, 2017

heated agreement

@dcheney-atlassian
Copy link

dcheney-atlassian commented May 18, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants